fix-dnsmasq-options - #48848
Draft
sgoveas wants to merge 7 commits into
Draft
Conversation
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-multi-nightly-baremetal-upi-ovn-ipv4-f14 periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetal-ha-agent-ipv4-static-disconnected-f7 |
Contributor
Author
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
Contributor
|
Issues in openshift/release go stale after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
the
lifecycle/stale
openshift-merge-robot
added
the
needs-rebase
sgoveas
force-pushed
the
fix-dnsmasq-options
branch
from
April 3, 2024 13:46
8f773db to
04f104a
Compare
openshift-merge-robot
removed
the
needs-rebase
sgoveas
force-pushed
the
fix-dnsmasq-options
branch
3 times, most recently
from
April 3, 2024 13:54
0daff0e to
d4d1fb1
Compare
sgoveas
force-pushed
the
fix-dnsmasq-options
branch
from
April 3, 2024 13:57
d4d1fb1 to
c07882d
Compare
openshift-ci-robot
added
the
rehearsals-ack
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-baremetal-ipi-ovn-ipv4-external-lb-f7 |
Contributor
|
@sgoveas: job(s): periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-baremetal-ipi-ovn-ipv4-external-lb-f7 either don't exist or were not found to be affected, and cannot be rehearsed |
sgoveas
force-pushed
the
fix-dnsmasq-options
branch
from
April 26, 2024 14:35
c07882d to
a8efe84
Compare
openshift-ci-robot
removed
the
rehearsals-ack
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-baremetal-ipi-ovn-ipv4-external-lb-f7 |
Contributor
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-baremetal-ipi-ovn-ipv4-arm-f7 |
Contributor
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
sgoveas
force-pushed
the
fix-dnsmasq-options
branch
from
April 27, 2024 11:05
a8efe84 to
9c7ce4e
Compare
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-baremetal-ipi-ovn-ipv4-arm-f7 |
Contributor
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-baremetal-ipi-ovn-ipv4-amd-f7 |
Contributor
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
|
@sgoveas: job(s): periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-baremetal-ipi-ovn-ipv4-amd-f7 either don't exist or were not found to be affected, and cannot be rehearsed |
Contributor
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
Contributor
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
Contributor
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
Contributor
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
Contributor
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-metal-ipi-ovn-ipv4-pxe-multi-arch-day2-amd-f14 |
Contributor
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (5)
ci-operator/step-registry/baremetal/lab/wait/baremetal-lab-wait-ref.yaml (1)
12-15:⚠️ Potential issue | 🟠 MajorLeave margin below the 72-hour step timeout.
CLUSTER_DURATIONis259200seconds, exactly 72 hours, and matches the step timeout. The wait process can be terminated before completion. Set the default duration below the timeout.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/baremetal/lab/wait/baremetal-lab-wait-ref.yaml` around lines 12 - 15, Update the CLUSTER_DURATION default in the baremetal lab wait configuration to a value below the 72-hour timeout, leaving sufficient margin for the wait process to complete before the step is terminated.ci-operator/step-registry/baremetal/lab/post/baremetal-lab-post-chain.yaml (1)
4-6:⚠️ Potential issue | 🔴 CriticalKeep the shared post chain focused on teardown and artifact collection.
Commenting out the gather refs and adding
baremetal-lab-waitmakes every consumer pause before cleanup and removes common failure-artifact collection. Restore the gather refs. Move the manual wait to a dedicated workflow or post chain.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/baremetal/lab/post/baremetal-lab-post-chain.yaml` around lines 4 - 6, Update the shared baremetal post chain to restore the baremetal-lab-agent-gather and gather references for common failure-artifact collection, and remove baremetal-lab-wait from this chain. Place the manual wait in a dedicated workflow or separate post chain instead.ci-operator/step-registry/baremetal/lab/ipi/multi-arch/baremetal-lab-ipi-multi-arch-commands.sh (1)
30-32:⚠️ Potential issue | 🟠 MajorReturn a failure for an invalid multi-arch request.
exit 0reports success when the additional worker architecture is not the requiredarm64value. Downstream installation can continue without the requested topology. Restore a non-zero exit status.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/baremetal/lab/ipi/multi-arch/baremetal-lab-ipi-multi-arch-commands.sh` around lines 30 - 32, Update the invalid additional-worker architecture branch in the multi-arch command logic to exit with a non-zero status instead of exit 0. Preserve the existing informational message and ensure invalid topology requests stop downstream installation as failures.ci-operator/step-registry/openshift/e2e/test/qe/openshift-e2e-test-qe-chain.yaml (1)
5-14:⚠️ Potential issue | 🔴 CriticalRestore the QE execution and reporting refs.
With Lines 5-14 commented out,
openshift-e2e-test-qeruns only the cluster-health check. Consumers can report success without QE coverage or reporting. Re-enable the refs, or create a dedicated reduced chain for this test path.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/openshift/e2e/test/qe/openshift-e2e-test-qe-chain.yaml` around lines 5 - 14, Restore the commented execution and reporting refs in the openshift-e2e-test-qe chain, including cucushift-pre, cucushift-e2e, openshift-extended-test, and openshift-e2e-test-qe-report, so the chain performs QE coverage and publishes its report rather than only running the cluster-health check.ci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/disconnected/baremetal-lab-ipi-conf-virtual-media-disconnected-chain.yaml (1)
20-24:⚠️ Potential issue | 🟡 MinorAlign the new documentation with the resource names.
Both documentation blocks still use identifiers from older definitions.
ci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/disconnected/baremetal-lab-ipi-conf-virtual-media-disconnected-chain.yaml#L20-L24: Replacebaremetal-lab-ipi-conf-basewithbaremetal-lab-ipi-conf-virtual-media-disconnected.ci-operator/step-registry/baremetal/lab/ipi/virtual-media/disconnected/baremetal-lab-ipi-virtual-media-disconnected-workflow.yaml#L14-L16: Replacebaremetal-lab-ipi-install-disconnectedwithbaremetal-lab-ipi-virtual-media-disconnected.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/disconnected/baremetal-lab-ipi-conf-virtual-media-disconnected-chain.yaml` around lines 20 - 24, Update the documentation identifiers to match the current resource names: in ci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/disconnected/baremetal-lab-ipi-conf-virtual-media-disconnected-chain.yaml lines 20-24, replace baremetal-lab-ipi-conf-base with baremetal-lab-ipi-conf-virtual-media-disconnected; in ci-operator/step-registry/baremetal/lab/ipi/virtual-media/disconnected/baremetal-lab-ipi-virtual-media-disconnected-workflow.yaml lines 14-16, replace baremetal-lab-ipi-install-disconnected with baremetal-lab-ipi-virtual-media-disconnected.
🧹 Nitpick comments (1)
ci-operator/step-registry/baremetal/lab/ipi/virtual-media/disconnected/baremetal-lab-ipi-virtual-media-disconnected-workflow.yaml (1)
3-10: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAdd or document the missing
testphase.This new workflow declares only
preandpost. Add the intendedtestchain or ref because step-registry workflows should definepre,test, andpostphases. Runmake validate-step-registrybefore merge.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/baremetal/lab/ipi/virtual-media/disconnected/baremetal-lab-ipi-virtual-media-disconnected-workflow.yaml` around lines 3 - 10, Add the missing test phase to the workflow steps, defining the intended test chain or ref between the existing pre and post phases. Ensure the workflow declares pre, test, and post consistently, then run make validate-step-registry.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-commands.sh`:
- Around line 96-98: Remove the unconditional
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE and MULTI_RELEASE_IMAGE exports from
the shared baremetal-lab-ipi-install command, preserving the step-registry
dependency values; set these variables upstream only in the specific workflows
that require the ci-ln-w7243dt payload.
---
Duplicate comments:
In
`@ci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/disconnected/baremetal-lab-ipi-conf-virtual-media-disconnected-chain.yaml`:
- Around line 20-24: Update the documentation identifiers to match the current
resource names: in
ci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/disconnected/baremetal-lab-ipi-conf-virtual-media-disconnected-chain.yaml
lines 20-24, replace baremetal-lab-ipi-conf-base with
baremetal-lab-ipi-conf-virtual-media-disconnected; in
ci-operator/step-registry/baremetal/lab/ipi/virtual-media/disconnected/baremetal-lab-ipi-virtual-media-disconnected-workflow.yaml
lines 14-16, replace baremetal-lab-ipi-install-disconnected with
baremetal-lab-ipi-virtual-media-disconnected.
In
`@ci-operator/step-registry/baremetal/lab/ipi/multi-arch/baremetal-lab-ipi-multi-arch-commands.sh`:
- Around line 30-32: Update the invalid additional-worker architecture branch in
the multi-arch command logic to exit with a non-zero status instead of exit 0.
Preserve the existing informational message and ensure invalid topology requests
stop downstream installation as failures.
In `@ci-operator/step-registry/baremetal/lab/post/baremetal-lab-post-chain.yaml`:
- Around line 4-6: Update the shared baremetal post chain to restore the
baremetal-lab-agent-gather and gather references for common failure-artifact
collection, and remove baremetal-lab-wait from this chain. Place the manual wait
in a dedicated workflow or separate post chain instead.
In `@ci-operator/step-registry/baremetal/lab/wait/baremetal-lab-wait-ref.yaml`:
- Around line 12-15: Update the CLUSTER_DURATION default in the baremetal lab
wait configuration to a value below the 72-hour timeout, leaving sufficient
margin for the wait process to complete before the step is terminated.
In
`@ci-operator/step-registry/openshift/e2e/test/qe/openshift-e2e-test-qe-chain.yaml`:
- Around line 5-14: Restore the commented execution and reporting refs in the
openshift-e2e-test-qe chain, including cucushift-pre, cucushift-e2e,
openshift-extended-test, and openshift-e2e-test-qe-report, so the chain performs
QE coverage and publishes its report rather than only running the cluster-health
check.
---
Nitpick comments:
In
`@ci-operator/step-registry/baremetal/lab/ipi/virtual-media/disconnected/baremetal-lab-ipi-virtual-media-disconnected-workflow.yaml`:
- Around line 3-10: Add the missing test phase to the workflow steps, defining
the intended test chain or ref between the existing pre and post phases. Ensure
the workflow declares pre, test, and post consistently, then run make
validate-step-registry.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 6e5f5f79-24ff-479b-a4da-1b6f39487e2d
⛔ Files ignored due to path filters (3)
ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (15)
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__multi-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-nightly.yamlci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/disconnected/OWNERSci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/disconnected/baremetal-lab-ipi-conf-virtual-media-disconnected-chain.metadata.jsonci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/disconnected/baremetal-lab-ipi-conf-virtual-media-disconnected-chain.yamlci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-commands.shci-operator/step-registry/baremetal/lab/ipi/multi-arch/baremetal-lab-ipi-multi-arch-commands.shci-operator/step-registry/baremetal/lab/ipi/virtual-media/disconnected/OWNERSci-operator/step-registry/baremetal/lab/ipi/virtual-media/disconnected/baremetal-lab-ipi-virtual-media-disconnected-workflow.metadata.jsonci-operator/step-registry/baremetal/lab/ipi/virtual-media/disconnected/baremetal-lab-ipi-virtual-media-disconnected-workflow.yamlci-operator/step-registry/baremetal/lab/post/baremetal-lab-post-chain.yamlci-operator/step-registry/baremetal/lab/wait/baremetal-lab-wait-ref.yamlci-operator/step-registry/openshift/e2e/test/qe/openshift-e2e-test-qe-chain.yaml
🚧 Files skipped from review as they are similar to previous changes (4)
- ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__amd64-nightly.yaml
- ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__multi-nightly.yaml
- ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml
- ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-nightly.yaml
Comment on lines
+96
to
+98
| export OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE="registry.build10.ci.openshift.org/ci-ln-w7243dt/release:latest" | ||
| export MULTI_RELEASE_IMAGE="registry.build10.ci.openshift.org/ci-ln-w7243dt/release:latest" | ||
|
|
Contributor
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n -C 5 \
'baremetal-lab-ipi-install|OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE|MULTI_RELEASE_IMAGE|ci-ln-w7243dt/release' \
ci-operator/step-registry ci-operator/configRepository: openshift/release
Length of output: 50374
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== exact references && file size =="
for expr in 'baremetal-lab-ipi-install' 'OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: *registry.build10.ci' 'MULTI_RELEASE_IMAGE: *registry.build10.ci' 'ci-ln-w7243dt/release' 'MULTI_RELEASE IMAGE'; do
echo "--- $expr"
rg -n "$expr" ci-operator/step-registry ci-operator/config || true
done
wc -l ci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-commands.sh
echo "== script prologue/context =="
sed -n '1,130p' ci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-commands.sh
echo "== matching baremetal config refs =="
rg -n -C 3 '\- ref: .*baremetal-lab-ipi-install|OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE|MULTI_RELEASE_IMAGE' ci-operator/config | grep -E '(baremetal-lab-ipi-install|registry.build10.ci' | sed -n '1,160p' || trueRepository: openshift/release
Length of output: 11206
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== all exact reference counts =="
python3 - <<'PY'
import subprocess
from pathlib import Path
terms = [
("baremetal-lab-ipi-install", "baremetal-lab-ipi-install"),
("exact ci-ln-w7243dt/release only line", "ci-ln-w7243dt/release:latest"),
]
for name, term in terms:
try:
out = subprocess.check_output(["rg", "-n", term, "ci-operator/step-registry", "ci-operator/config"], text=True)
except subprocess.CalledProcessError as e:
out = e.output if e.output else ""
print(f"--- {name}: {len(out.splitlines()) if out else 0}")
if out:
print("\n".join(out.splitlines()[:160]))
if out.count("\n") >= 160:
print("\n... truncated")
PY
echo "== reference file =="
cat -n ci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-ref.yaml
echo "== baremetal step files outline =="
find ci-operator/step-registry/baremetal/lab/ipi/install -maxdepth 2 -type f -print | sortRepository: openshift/release
Length of output: 7525
Scope the release-image override to the intended jobs.
baremetal-lab-ipi-install is used by multiple baremetal-install workflows, but ci-ln-w7243dt/release:latest is set inside the shared install command and is not documented as required by those workflows. Keep the step-registry dependency values unchanged unless every caller must use this payload, or override these variables upstream in the specific workflows that need them.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-commands.sh`
around lines 96 - 98, Remove the unconditional
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE and MULTI_RELEASE_IMAGE exports from
the shared baremetal-lab-ipi-install command, preserving the step-registry
dependency values; set these variables upstream only in the specific workflows
that require the ci-ln-w7243dt payload.
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
Contributor
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Closed
use 2 workers for bmaas add disconnected vmedia 4.22 job periodic jobs not created
with periodics
Contributor
|
[REHEARSALNOTIFIER]
A total of 2395 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Contributor
Author
|
/pj-rehearse rehearse-48848-periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
Contributor
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
|
@sgoveas: job(s): rehearse-48848-periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 either don't exist or were not found to be affected, and cannot be rehearsed |
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
Contributor
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
|
@sgoveas: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit