Skip to content

Bump the kubernetes group across 1 directory with 6 updates#544

Open
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/go_modules/kubernetes-f5654d70b0
Open

Bump the kubernetes group across 1 directory with 6 updates#544
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/go_modules/kubernetes-f5654d70b0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Jun 4, 2026

Bumps the kubernetes group with 3 updates in the / directory: k8s.io/api, k8s.io/apiextensions-apiserver and sigs.k8s.io/controller-runtime.

Updates k8s.io/api from 0.35.4 to 0.36.1

Commits
  • 25001c8 Update dependencies to v0.36.1 tag
  • 879d396 Merge remote-tracking branch 'origin/master' into release-1.36
  • 030d81f Update github.com/moby/spdystream from v0.5.0 to v0.5.1
  • aef6eb6 Add granular authorization for DRA ResourceClaim status updates
  • 91061ea Merge pull request #136589 from tosi3k/preemption-mode
  • e6b81e2 Add Workload-Aware Preemption fields to Workload and PodGroup APIs
  • f8fce2e Merge pull request #136989 from nojnhuh/podgroup-resourceclaim
  • b928f5e Workload API: PodGroup ResourceClaims (KEP-5729)
  • 61bd78e Merge pull request #137190 from everpeace/KEP-5491-alpha
  • 6bf46eb Merge pull request #137028 from nmn3m/feature/dra-resource-pool-status
  • Additional commits viewable in compare view

Updates k8s.io/apiextensions-apiserver from 0.35.4 to 0.36.1

Commits
  • 5b822b1 Update dependencies to v0.36.1 tag
  • 4cd8c3d Merge remote-tracking branch 'origin/master' into release-1.36
  • c2fd557 Merge pull request #138346 from dashpole/update_otel_prop
  • 1daa309 Merge remote-tracking branch 'origin/master' into release-1.36
  • 1551264 Update github.com/moby/spdystream from v0.5.0 to v0.5.1
  • 6c97d2b update go.opentelemetry.io/otel to v1.41.0
  • 862c52a update google.golang.org/grpc to v1.79.3
  • abac065 Merge pull request #137849 from bryantbiggs/deps/update-kube-openapi
  • 7acee75 Merge pull request #137843 from pacoxu/cobra-v1.10.2
  • 612f1d8 dependencies: bump kube-openapi to drop ginkgo/gomega indirect deps
  • Additional commits viewable in compare view

Updates k8s.io/apimachinery from 0.35.4 to 0.36.1

Commits
  • 7af103a Update dependencies to v0.36.1 tag
  • efb7f26 Merge remote-tracking branch 'origin/master' into release-1.36
  • d966e56 Update github.com/moby/spdystream from v0.5.0 to v0.5.1
  • 79b3632 Merge pull request #137864 from yongruilin/dv-dra-mismatch
  • a8822f7 Add slice and map union member support with tests
  • 7dba2d0 Use IsZero instead of IsNil for union ratcheting check
  • d95710f Fix union validation ratcheting when oldObj is nil
  • 729062d Merge pull request #137849 from bryantbiggs/deps/update-kube-openapi
  • 13b12e6 dependencies: bump kube-openapi to drop ginkgo/gomega indirect deps
  • 27f4670 Merge pull request #136657 from Jefftree/sharding-test
  • Additional commits viewable in compare view

Updates k8s.io/client-go from 0.35.4 to 0.36.1

Commits
  • 55ef15a Update dependencies to v0.36.1 tag
  • f22a53e Merge remote-tracking branch 'origin/master' into release-1.36
  • a948641 Update github.com/moby/spdystream from v0.5.0 to v0.5.1
  • 7e44ffc Add Workload-Aware Preemption fields to Workload and PodGroup APIs
  • df2d882 Merge pull request #136989 from nojnhuh/podgroup-resourceclaim
  • 4eece52 Workload API: PodGroup ResourceClaims (KEP-5729)
  • 3d35c51 Merge pull request #137190 from everpeace/KEP-5491-alpha
  • 0434117 Merge pull request #137028 from nmn3m/feature/dra-resource-pool-status
  • ba785be Drop CSR analogy, mark ObjectMeta +required,reduce limits (maxItems=500, maxL...
  • 4a9c878 Add ResourcePoolStatusRequest API types and generated code
  • Additional commits viewable in compare view

Updates k8s.io/utils from 0.0.0-20251002143259-bc988d571ff4 to 0.0.0-20260210185600-b8788abfbbc2

Commits

Updates sigs.k8s.io/controller-runtime from 0.23.3 to 0.24.1

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.24.1

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.24.0...v0.24.1

v0.24.0

⚠️ Breaking Changes

🐛 Bug Fixes

  • Cache: Fix IndexField blocking until informer is synced (#3445)
  • Cache: Wait for cache sync when ReaderFailOnMissingInformer is true (#3425)
  • Client: Update typed ApplyConfigurations with server response (#3475)
  • Fakeclient: Fix SSA status patch resource version check (#3443)
  • Fakeclient: Fix panic when using CRs with embedded pointer structs (#3431)
  • Fakeclient: Fix status apply if existing object has managedFields set (#3430)
  • Fakeclient: Retry GenerateName on AlreadyExists collisions (#3498)
  • HTTP servers: Wire up base context into http servers (#3452)

🌱 Others

  • Builder/Webhooks: Remove deprecated custom path function (#3465)
  • Cache: Test cache reader waits for cache sync (#3434)
  • Certwatcher: Deflake certwatcher tests (#3457)
  • Dependencies: Use forked version of btree (#3449)
  • Envtest: Ensure envtest stops the whole process group (#3447)
  • Logging: Add missing space in zap-log-level flag description (#3492)
  • Misc: Adopt new(x) over ptr.To(x) and re-enable newexpr lint (#3489)
  • Owners: Cleanup (#3453)
  • Recorder: Add logger into context for structured logging (#3454)
  • Recorder: Switch to StartLogging for event debug logs (#3451)
  • Scheme: Deprecate the scheme builder (#3461)
  • Source/Kind: Improve logging for dynamic type kind source (#3494)
  • Webhooks: Reduce memory usage of default webhooks (#3463 #3468)

🌱 CI & linters

  • Chore: Update golangci-lint version to v2.8.0 (#3448)
  • Chore: Update golangci-lint version to v2.10.1 (#3470)
  • Chore: Update golangci-lint version to v2.11.3 (#3482)
  • Migrate away from custom GitHub action approval workflow (#3491)
  • Release: Auto-create git tags for the tools/setup-envtest submodule (#3476)

📖 Additionally, there has been 1 contribution to our documentation. (#3477)

Dependencies

... (truncated)

Commits
  • 3be3f1b Merge pull request #3516 from k8s-infra-cherrypick-robot/cherry-pick-3515-to-...
  • 0f7b33d Fix regression in Apply typed error handling
  • d3eaef3 Merge pull request #3475 from alvaroaleman/fixfix
  • 3296f32 🐛 Update typed Applyconfigurations with server response
  • c8b4b9d Merge pull request #3506 from troy0820/troy0820/update-deps-k8s
  • 557c314 update to k8s.io v1.36.0
  • e4a998c Merge pull request #3499 from kubernetes-sigs/dependabot/github_actions/all-g...
  • 1a31c56 Merge pull request #3498 from vieux/fix-fake-client-generatename-retry
  • 80bc294 fakeclient: retry GenerateName on AlreadyExists collisions (match K8s 1.32 be...
  • 77b730a 🌱 Bump the all-github-actions group with 2 updates
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain to version 1.26.0
    • Upgraded Kubernetes dependencies to version 0.36.1
    • Updated controller-runtime to version 0.24.1
    • Updated various indirect dependencies including Prometheus common, protobuf, and Kubernetes components

Bumps the kubernetes group with 3 updates in the / directory: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) and [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime).


Updates `k8s.io/api` from 0.35.4 to 0.36.1
- [Commits](kubernetes/api@v0.35.4...v0.36.1)

Updates `k8s.io/apiextensions-apiserver` from 0.35.4 to 0.36.1
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.35.4...v0.36.1)

Updates `k8s.io/apimachinery` from 0.35.4 to 0.36.1
- [Commits](kubernetes/apimachinery@v0.35.4...v0.36.1)

Updates `k8s.io/client-go` from 0.35.4 to 0.36.1
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.35.4...v0.36.1)

Updates `k8s.io/utils` from 0.0.0-20251002143259-bc988d571ff4 to 0.0.0-20260210185600-b8788abfbbc2
- [Commits](https://github.com/kubernetes/utils/commits)

Updates `sigs.k8s.io/controller-runtime` from 0.23.3 to 0.24.1
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.23.3...v0.24.1)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-version: 0.36.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: kubernetes
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-version: 0.36.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: kubernetes
- dependency-name: k8s.io/apimachinery
  dependency-version: 0.36.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: kubernetes
- dependency-name: k8s.io/client-go
  dependency-version: 0.36.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: kubernetes
- dependency-name: k8s.io/utils
  dependency-version: 0.0.0-20260210185600-b8788abfbbc2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: kubernetes
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-version: 0.24.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: kubernetes
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Jun 4, 2026
@github-actions github-actions Bot enabled auto-merge (squash) June 4, 2026 02:57
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Walkthrough

This PR updates go.mod to upgrade the Go toolchain to version 1.26.0 and bumps core Kubernetes dependencies to 0.36.1, including k8s.io/api, k8s.io/client-go, and sigs.k8s.io/controller-runtime to 0.24.1. It also updates numerous indirect dependencies to maintain compatibility across the Kubernetes ecosystem.

Changes

Dependency Version Upgrade

Layer / File(s) Summary
Go toolchain and core Kubernetes dependencies
go.mod
Go toolchain declared version updated from 1.25.7 to 1.26.0, and core Kubernetes modules (k8s.io/api, k8s.io/apiextensions-apiserver, k8s.io/apimachinery, k8s.io/client-go, k8s.io/utils) bumped to 0.36.1, with sigs.k8s.io/controller-runtime advanced to 0.24.1.
Indirect dependencies upgrade
go.mod
Indirect dependencies including github.com/prometheus/common (0.67.5), golang.org/x/time (0.14.0), google.golang.org/protobuf, and Kubernetes-related indirect modules (k8s.io/component-base, k8s.io/kube-openapi, k8s.io/streaming) are updated to versions compatible with the Kubernetes 0.36.1 ecosystem.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • openshift/managed-cluster-validating-webhooks#475: Both PRs are dependabot-only go.mod version bumps for the Kubernetes/controller-runtime dependency set (including sigs.k8s.io/controller-runtime and k8s.io/*), so the changes overlap at the module/version level.
  • openshift/managed-cluster-validating-webhooks#489: Both PRs update the same Kubernetes Go modules in go.mod (e.g., k8s.io/api, k8s.io/apiextensions-apiserver, k8s.io/apimachinery, k8s.io/client-go) via version bumps, so the main PR is directly related to the dependency update scope of the retrieved PR.

Suggested reviewers

  • feichashao
  • clcollins
  • samanthajayasinghe
🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Single Node Openshift (Sno) Test Compatibility ⚠️ Warning New test file test/e2e/validation_webhook_tests.go has SNO-incompatible Ginkgo tests that assume multi-node clusters with distinct master/infra nodes, lacking SNO protection mechanisms. Add [Skipped:SingleReplicaTopology] labels or guard with exutil.IsSingleNode() checks that skip tests on SNO deployments.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: bumping Kubernetes-related dependencies with the specific count of 6 updates across the repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed All 27 Ginkgo tests in test/e2e/validation_webhook_tests.go use stable names without dynamic content: no pod/node names, timestamps, UUIDs, IPs, or format strings.
Test Structure And Quality ✅ Passed PR only modifies go.mod/go.sum for dependency version bumps; no Ginkgo test code was modified, making the test quality check inapplicable.
Microshift Test Compatibility ✅ Passed This PR only changes go.mod (Kubernetes dependency version bumps). It does not add any new Ginkgo e2e tests, so the MicroShift test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates Go module dependencies in go.mod/go.sum; does not add or modify deployment manifests, operator code, or controllers, so topology-awareness check does not apply.
Ote Binary Stdout Contract ✅ Passed PR only modifies go.mod/go.sum (dependency updates). No source code changes, so no new stdout violations introduced. Pre-existing klog violation in master is unrelated to this dependency bump.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Custom check is not applicable: This PR only updates go.mod and go.sum dependency versions; no new Ginkgo e2e tests are added.
No-Weak-Crypto ✅ Passed No weak crypto (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom implementations, or non-constant-time secret comparisons detected. PR only updates dependency versions in go.mod with no code changes.
Container-Privileges ✅ Passed PR modifies only go.mod/go.sum (Go dependency versions). No container privilege settings, K8s manifests, or security contexts are changed, so container-privileges check does not apply.
No-Sensitive-Data-In-Logs ✅ Passed PR updates dependencies only. Existing logs use request.AdmissionRequest (safe metadata), not request.Object (secrets). No passwords, tokens, keys, or PII logging found.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dependabot/go_modules/kubernetes-f5654d70b0

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from clcollins and feichashao June 4, 2026 02:57
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign rogbas for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2026

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Line 85: The go.mod currently pins a pseudo-version for the protobuf module
(google.golang.org/protobuf v1.36.12-0.20260120151049-f2248ac996af) which
weakens reproducibility; update go.mod to use the latest stable semver (e.g.,
google.golang.org/protobuf v1.36.11) and then run `go mod tidy`/`go get` to
re-resolve dependencies, or if that exact commit is truly required, add a short
justification comment in the repository docs and a go.mod comment explaining why
the pseudo-version was chosen; locate the google.golang.org/protobuf entry in
go.mod to make this change.
- Line 91: Add a short rationale entry to the PR/commit message and project
dependency review describing why k8s.io/streaming v0.36.1 is present (use the
exact module string "k8s.io/streaming v0.36.1" and the output from running `go
mod why -m k8s.io/streaming` which shows it is pulled via
`k8s.io/client-go/tools/remotecommand -> k8s.io/streaming/pkg/httpstream`,
`github.com/openshift/managed-cluster-validating-webhooks/test/e2e`, and
`sigs.k8s.io/e2e-framework/klient/k8s/resources`), and append the dependency
review trail with the license information for k8s.io/streaming v0.36.1 (name and
compatibility) plus a known-CVE check for that exact version (e.g.,
results/links from osv.dev or equivalent vulnerability database) so the PR
includes both the “why” and security/license verification.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 61e62022-f0a8-4472-bdab-a80b7304a484

📥 Commits

Reviewing files that changed from the base of the PR and between bb647e6 and e7353ce.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Comment thread go.mod
golang.org/x/time v0.14.0 // indirect
golang.org/x/tools v0.45.0 // indirect
google.golang.org/protobuf v1.36.11 // indirect
google.golang.org/protobuf v1.36.12-0.20260120151049-f2248ac996af // indirect
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check whether a stable tagged protobuf version can replace the pseudo-version
set -euo pipefail
curl -fsSL https://proxy.golang.org/google.golang.org/protobuf/@v/list | tail -n 30
echo "Current go.mod entry:"
rg -n 'google\.golang\.org/protobuf' go.mod

Repository: openshift/managed-cluster-validating-webhooks

Length of output: 439


🏁 Script executed:

#!/bin/bash
set -euo pipefail

mod="google.golang.org/protobuf"

# Fetch version list once and query for the stable tag(s) around the pseudo-version base
versions="$(curl -fsSL "https://proxy.golang.org/${mod}/@v/list")"

echo "Has stable v1.36.12 tag? =>"
echo "$versions" | rg -n '^v1\.36\.12$' || echo "NO"

echo
echo "Closest stable tags to v1.36.12 (sorted):"
# Extract v1.36.xx stable tags (exclude pseudo versions) and show a small window
echo "$versions" | rg '^v1\.36\.[0-9]+$' | sort -V | tail -n 10

echo
echo "Has later stable tags beyond v1.36.12? (show last 10 stable tags overall)"
echo "$versions" | rg '^v[0-9]+\.[0-9]+\.[0-9]+$' | sort -V | tail -n 10

echo
echo "Current go.mod entry:"
rg -n 'google\.golang\.org/protobuf' go.mod

Repository: openshift/managed-cluster-validating-webhooks

Length of output: 507


Avoid pseudo-version protobuf in production dependency set

go.mod pins google.golang.org/protobuf v1.36.12-0.20260120151049-f2248ac996af // indirect, which is a Go pseudo-version (not a stable semver tag). The module proxy lists no stable v1.36.12 tag, with the latest stable protobuf tags ending at v1.36.11, so this pin tracks an untagged commit and weakens reproducibility versus stable releases.

  • Prefer google.golang.org/protobuf v1.36.11 (or the latest available stable) and re-resolve deps, or add explicit justification for why this specific pseudo-version is required.
google.golang.org/protobuf v1.36.12-0.20260120151049-f2248ac996af // indirect
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 85, The go.mod currently pins a pseudo-version for the
protobuf module (google.golang.org/protobuf
v1.36.12-0.20260120151049-f2248ac996af) which weakens reproducibility; update
go.mod to use the latest stable semver (e.g., google.golang.org/protobuf
v1.36.11) and then run `go mod tidy`/`go get` to re-resolve dependencies, or if
that exact commit is truly required, add a short justification comment in the
repository docs and a go.mod comment explaining why the pseudo-version was
chosen; locate the google.golang.org/protobuf entry in go.mod to make this
change.

Comment thread go.mod
k8s.io/kube-openapi v0.0.0-20250910181357-589584f1c912 // indirect
k8s.io/component-base v0.36.1 // indirect
k8s.io/kube-openapi v0.0.0-20260317180543-43fb72c5454a // indirect
k8s.io/streaming v0.36.1 // indirect
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Identify why k8s.io/streaming was introduced in module graph and gather license metadata reference points
set -euo pipefail
rg -n 'k8s\.io/streaming' go.mod go.sum
echo "If available in your environment, run: go mod graph | rg 'k8s.io/streaming'"

Repository: openshift/managed-cluster-validating-webhooks

Length of output: 388


🏁 Script executed:

#!/bin/bash
set -euo pipefail
rg -n 'k8s\.io/streaming' go.mod go.sum
go mod why -m k8s.io/streaming

Repository: openshift/managed-cluster-validating-webhooks

Length of output: 513


Add dependency rationale + complete license/security trail for k8s.io/streaming v0.36.1 (indirect)

go.mod:91 introduces k8s.io/streaming v0.36.1 // indirect (checksummed in go.sum). go mod why -m k8s.io/streaming shows it’s pulled via:

  • k8s.io/client-go/tools/remotecommandk8s.io/streaming/pkg/httpstream
  • github.com/openshift/managed-cluster-validating-webhooks/test/e2e
  • sigs.k8s.io/e2e-framework/klient/k8s/resources

Add brief PR evidence for this “why” (from go mod why) and extend the dependency review trail to include license compatibility for k8s.io/streaming v0.36.1 and a known-CVE check for that exact version (e.g., via osv.dev).

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 91, Add a short rationale entry to the PR/commit message and
project dependency review describing why k8s.io/streaming v0.36.1 is present
(use the exact module string "k8s.io/streaming v0.36.1" and the output from
running `go mod why -m k8s.io/streaming` which shows it is pulled via
`k8s.io/client-go/tools/remotecommand -> k8s.io/streaming/pkg/httpstream`,
`github.com/openshift/managed-cluster-validating-webhooks/test/e2e`, and
`sigs.k8s.io/e2e-framework/klient/k8s/resources`), and append the dependency
review trail with the license information for k8s.io/streaming v0.36.1 (name and
compatibility) plus a known-CVE check for that exact version (e.g.,
results/links from osv.dev or equivalent vulnerability database) so the PR
includes both the “why” and security/license verification.

@diakovnec
Copy link
Copy Markdown
Contributor

/retest

@diakovnec
Copy link
Copy Markdown
Contributor

/retest

1 similar comment
@diakovnec
Copy link
Copy Markdown
Contributor

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-binary-build-success e7353ce link true /test e2e-binary-build-success
ci/prow/pr-check e7353ce link true /test pr-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant