Updating Go toolset 1.26#545
Conversation
|
Warning Review limit reached
More reviews will be available in 47 minutes and 24 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
WalkthroughThis PR updates the Go builder base image in the Dockerfile from ubi9/go-toolset version 1.25.9 to version 1.26. The change is isolated to a single line in the BASE_IMAGE argument. ChangesGo toolset base image update
🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 12 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
build/Dockerfile (1)
1-38: ⚡ Quick winAdd HEALTHCHECK instruction per security guidelines.
The Dockerfile lacks a HEALTHCHECK instruction, which is required by the coding guidelines for container security. A health check enables orchestrators to monitor container health and restart unhealthy instances.
➕ Suggested HEALTHCHECK addition
Add after line 25 (before LABEL):
HEALTHCHECK --interval=30s --timeout=3s --start-period=5s --retries=3 \ CMD ["/usr/local/bin/webhooks", "--health-check"] || exit 1Note: Adjust the health check command based on the actual health endpoint provided by your webhook service. If the service exposes an HTTP health endpoint, use:
HEALTHCHECK --interval=30s --timeout=3s --start-period=5s --retries=3 \ CMD curl -f http://localhost:8080/healthz || exit 1As per coding guidelines: "HEALTHCHECK defined".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@build/Dockerfile` around lines 1 - 38, Dockerfile is missing a required HEALTHCHECK instruction; add a HEALTHCHECK before the LABEL block that probes the running webhooks process. Implement a healthcheck that matches how the service exposes health (either invoke the binary at /usr/local/bin/webhooks with a --health-check flag or curl an HTTP endpoint like http://localhost:8080/healthz), e.g. use HEALTHCHECK with sensible --interval/--timeout/--start-period/--retries values and a CMD that returns non-zero on failure so the orchestrator can detect and restart unhealthy containers; place it after the ENTRYPOINT/User directives and before the LABELs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@build/Dockerfile`:
- Line 1: The BASE_IMAGE ARG is pinned to a specific build via the suffix
"-1780490420"; update the ARG BASE_IMAGE value used in the Dockerfile (the ARG
named BASE_IMAGE) to use the floating Red Hat tag ":1.26" instead of the pinned
":1.26-1780490420" so the build follows the guideline to let Red Hat manage
updates.
- Line 1: Update the pipeline and Dockerfile so Tekton uses Go 1.26 and harden
the image: change the pipeline build-args in
.tekton/managed-cluster-validating-webhooks-pull-request.yaml and
.tekton/managed-cluster-validating-webhooks-push.yaml to set BASE_IMAGE to the
Go 1.26 builder (matching the Dockerfile), change ARG BASE_IMAGE in
build/Dockerfile to use the floating Red Hat tag (e.g.,
registry.access.redhat.com/ubi9/go-toolset:1.26) instead of the build-suffix
pin, add a HEALTHCHECK instruction in build/Dockerfile to probe the
service/container health, and replace the broad COPY . . ./ with explicit COPY
lines that only copy the required source and artifact files (avoid copying the
entire build context).
---
Nitpick comments:
In `@build/Dockerfile`:
- Around line 1-38: Dockerfile is missing a required HEALTHCHECK instruction;
add a HEALTHCHECK before the LABEL block that probes the running webhooks
process. Implement a healthcheck that matches how the service exposes health
(either invoke the binary at /usr/local/bin/webhooks with a --health-check flag
or curl an HTTP endpoint like http://localhost:8080/healthz), e.g. use
HEALTHCHECK with sensible --interval/--timeout/--start-period/--retries values
and a CMD that returns non-zero on failure so the orchestrator can detect and
restart unhealthy containers; place it after the ENTRYPOINT/User directives and
before the LABELs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 57b45ff3-a060-4ee8-8e23-1a9be8cd2cb8
📒 Files selected for processing (1)
build/Dockerfile
|
@diakovnec: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: diakovnec, feichashao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
We have PRs raised by the bot failing and require updating the Go toolset to version 1.26. Kube dependencies to v0.36.1, which pulled in go >= 1.26.0
After checking, I can see that it was released today https://catalog.redhat.com/en/software/containers/rhel9/go-toolset/61df08166d9a1b7b2aab2344#overview
Summary by CodeRabbit