Skip to content

OCPBUGS-102043: Bump golang.org/x/net to v0.53.0 in 4.22 - #131

Open
katekeiroz-dev wants to merge 1 commit into
openshift:release-4.22from
katekeiroz-dev:update-xnet-4.22
Open

OCPBUGS-102043: Bump golang.org/x/net to v0.53.0 in 4.22#131
katekeiroz-dev wants to merge 1 commit into
openshift:release-4.22from
katekeiroz-dev:update-xnet-4.22

Conversation

@katekeiroz-dev

Copy link
Copy Markdown

Summary

This PR addresses CVE-2026-33814 by bumping golang.org/x/net from v0.48.0 to v0.53.0 on release-4.22. The patched HTTP/2 client rejects SETTINGS_MAX_FRAME_SIZE=0 instead of looping on CONTINUATION writes.

Changes

  • Updated golang.org/x/net from v0.48.0 to v0.53.0
  • Ran go mod tidy and go mod vendor
  • Go version unchanged at 1.25.0 (Path A: direct update)

CVE Details

CVE-2026-33814 / GO-2026-4918: HTTP/2 client infinite loop DoS when a peer sends SETTINGS_MAX_FRAME_SIZE=0.

  • Severity: Important
  • Affected: golang.org/x/net/http2 < v0.53.0
  • Fix: processSettingsNoWrite now validates all SETTINGS via Setting.Valid() (rejects MAX_FRAME_SIZE < 16384)

Stdlib net/http is separately listed as fixed in Go 1.25.10 / 1.26.3. This PR covers the vendored x/net client path; golang-builder rebase is still needed for stdlib.

Upstream References

Test Plan

  • Go version unchanged (go 1.25.0)
  • Vendored processSettingsNoWrite calls s.Valid() before applying SettingMaxFrameSize
  • Unit tests / CI
  • QE verification

Related

Made with Cursor

Update golang.org/x/net from v0.48.0 to v0.53.0 to address
CVE-2026-33814 (HTTP/2 SETTINGS_MAX_FRAME_SIZE=0 infinite loop).

The patched processSettingsNoWrite validates SETTINGS via Setting.Valid()
so a zero MAX_FRAME_SIZE is rejected instead of hanging the client.

Go version remains 1.25.0.

Upstream PR: https://github.com/kubernetes-sigs/cloud-provider-vsphere/pull/1730
Upstream-commit: 1449e9b

Related: OCPBUGS-102043
Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci

openshift-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@katekeiroz-dev: This pull request references Jira Issue OCPBUGS-102043, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-102043 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

This PR addresses CVE-2026-33814 by bumping golang.org/x/net from v0.48.0 to v0.53.0 on release-4.22. The patched HTTP/2 client rejects SETTINGS_MAX_FRAME_SIZE=0 instead of looping on CONTINUATION writes.

Changes

  • Updated golang.org/x/net from v0.48.0 to v0.53.0
  • Ran go mod tidy and go mod vendor
  • Go version unchanged at 1.25.0 (Path A: direct update)

CVE Details

CVE-2026-33814 / GO-2026-4918: HTTP/2 client infinite loop DoS when a peer sends SETTINGS_MAX_FRAME_SIZE=0.

  • Severity: Important
  • Affected: golang.org/x/net/http2 < v0.53.0
  • Fix: processSettingsNoWrite now validates all SETTINGS via Setting.Valid() (rejects MAX_FRAME_SIZE < 16384)

Stdlib net/http is separately listed as fixed in Go 1.25.10 / 1.26.3. This PR covers the vendored x/net client path; golang-builder rebase is still needed for stdlib.

Upstream References

Test Plan

  • Go version unchanged (go 1.25.0)
  • Vendored processSettingsNoWrite calls s.Valid() before applying SettingMaxFrameSize
  • Unit tests / CI
  • QE verification

Related

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 87e0251e-7920-4ab5-b5c4-cd5cd0341081

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@katekeiroz-dev

Copy link
Copy Markdown
Author

/test regression-clusterinfra-vsphere-ipi-ccm

@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown

@katekeiroz-dev: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants