OCPBUGS-102043: Bump golang.org/x/net to v0.53.0 in 4.22 - #131
OCPBUGS-102043: Bump golang.org/x/net to v0.53.0 in 4.22#131katekeiroz-dev wants to merge 1 commit into
Conversation
Update golang.org/x/net from v0.48.0 to v0.53.0 to address CVE-2026-33814 (HTTP/2 SETTINGS_MAX_FRAME_SIZE=0 infinite loop). The patched processSettingsNoWrite validates SETTINGS via Setting.Valid() so a zero MAX_FRAME_SIZE is rejected instead of hanging the client. Go version remains 1.25.0. Upstream PR: https://github.com/kubernetes-sigs/cloud-provider-vsphere/pull/1730 Upstream-commit: 1449e9b Related: OCPBUGS-102043 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Skipping CI for Draft Pull Request. |
|
@katekeiroz-dev: This pull request references Jira Issue OCPBUGS-102043, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test regression-clusterinfra-vsphere-ipi-ccm |
|
@katekeiroz-dev: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
This PR addresses CVE-2026-33814 by bumping
golang.org/x/netfrom v0.48.0 to v0.53.0 on release-4.22. The patched HTTP/2 client rejectsSETTINGS_MAX_FRAME_SIZE=0instead of looping on CONTINUATION writes.Changes
golang.org/x/netfrom v0.48.0 to v0.53.0go mod tidyandgo mod vendorCVE Details
CVE-2026-33814 / GO-2026-4918: HTTP/2 client infinite loop DoS when a peer sends
SETTINGS_MAX_FRAME_SIZE=0.golang.org/x/net/http2< v0.53.0processSettingsNoWritenow validates all SETTINGS viaSetting.Valid()(rejects MAX_FRAME_SIZE < 16384)Stdlib
net/httpis separately listed as fixed in Go 1.25.10 / 1.26.3. This PR covers the vendored x/net client path; golang-builder rebase is still needed for stdlib.Upstream References
1730Test Plan
go 1.25.0)processSettingsNoWritecallss.Valid()before applyingSettingMaxFrameSizeRelated
Made with Cursor