OCPBUGS-103963: Replace golang.org/x/net with sustaining fork for CVE-2026-33814 in 4.20

[katekeiroz-dev]

Summary

This PR addresses CVE-2026-33814 by replacing golang.org/x/net with the OpenShift sustaining fork that contains the security fix. The upstream patched version requires a Go upgrade that release-4.20 cannot take.

Changes

• Added replace directive: golang.org/x/net => github.com/openshift-sustaining/net v0.50.0-sec.3
• Updated go.mod and go.sum
• Vendored the patched dependency

Why Replace Directive?

golang.org/x/net v0.53.0 requires Go 1.25.0+, but release-4.20 must keep Go 1.24.0. The sustaining tag v0.50.0-sec.3 backports the CVE-2026-33814 Setting.Valid() check without a Go minor upgrade.

CVE Details

CVE-2026-33814 / GO-2026-4918: HTTP/2 client infinite loop DoS when a peer sends SETTINGS_MAX_FRAME_SIZE=0.

Stdlib net/http is separately listed as fixed in Go 1.25.10 / 1.26.3 (no 1.24.x patch listed). This PR covers the vendored x/net client path.

Upstream References

• UPSTREAM status: <carry>
• Sustaining fork: https://github.com/openshift-sustaining/net/releases/tag/v0.50.0-sec.3

Test Plan

• Go version unchanged (go 1.24.0)
• Vendored processSettingsNoWrite calls s.Valid()
• Unit tests / CI
• QE verification

Related

• Jira: OCPBUGS-103963
• Go Vuln DB: GO-2026-4918
• 4.22 sibling (Path A): OCPBUGS-102043: Bump golang.org/x/net to v0.53.0 in 4.22 #131
• 4.21 sibling (Path C): OCPBUGS-104185: Replace golang.org/x/net with sustaining fork for CVE-2026-33814 in 4.21 #132

Made with Cursor

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@katekeiroz-dev: This pull request references Jira Issue OCPBUGS-103963, which is invalid:

• expected dependent Jira Issue OCPBUGS-104185 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

This PR addresses CVE-2026-33814 by replacing golang.org/x/net with the OpenShift sustaining fork that contains the security fix. The upstream patched version requires a Go upgrade that release-4.20 cannot take.

Changes

• Added replace directive: golang.org/x/net => github.com/openshift-sustaining/net v0.50.0-sec.3
• Updated go.mod and go.sum
• Vendored the patched dependency

Why Replace Directive?

golang.org/x/net v0.53.0 requires Go 1.25.0+, but release-4.20 must keep Go 1.24.0. The sustaining tag v0.50.0-sec.3 backports the CVE-2026-33814 Setting.Valid() check without a Go minor upgrade.

CVE Details

CVE-2026-33814 / GO-2026-4918: HTTP/2 client infinite loop DoS when a peer sends SETTINGS_MAX_FRAME_SIZE=0.

Stdlib net/http is separately listed as fixed in Go 1.25.10 / 1.26.3 (no 1.24.x patch listed). This PR covers the vendored x/net client path.

Upstream References

• UPSTREAM status: <carry>
• Sustaining fork: https://github.com/openshift-sustaining/net/releases/tag/v0.50.0-sec.3

Test Plan

• Go version unchanged (go 1.24.0)
• Vendored processSettingsNoWrite calls s.Valid()
• Unit tests / CI
• QE verification

Related

• Jira: OCPBUGS-103963
• Go Vuln DB: GO-2026-4918
• 4.22 sibling (Path A): OCPBUGS-102043: Bump golang.org/x/net to v0.53.0 in 4.22 #131
• 4.21 sibling (Path C): OCPBUGS-104185: Replace golang.org/x/net with sustaining fork for CVE-2026-33814 in 4.21 #132

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c983b93c-7be9-4086-8347-c942c1f6cd3d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elmiko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[katekeiroz-dev]

/ok-to-test

[openshift-ci]

@katekeiroz-dev: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.