Skip to content

[release-4.21] OCPBUGS-115261: Fix node.kubernetes.io/exclude-from-external-load-balancers on masters - #142

Open
openshift-cherrypick-robot wants to merge 2 commits into
openshift:release-4.21from
openshift-cherrypick-robot:cherry-pick-130-to-release-4.21
Open

[release-4.21] OCPBUGS-115261: Fix node.kubernetes.io/exclude-from-external-load-balancers on masters#142
openshift-cherrypick-robot wants to merge 2 commits into
openshift:release-4.21from
openshift-cherrypick-robot:cherry-pick-130-to-release-4.21

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #130

/assign openshift-cherrypick-robot

/cherrypick release-4.20

…balancers on masters

We previously used allHaveNodePrefix() to ensure that if a master
instance group contained the bootstrap machine this would not cause it
to be excluded from re-use. This worked because the bootstrap machine's
name has the same prefix as all other machines in the cluster.

However, this logic unconditionally always included the master instance
group. If the masters are labelled with
node.kubernetes.io/exclude-from-external-load-balancers the CCM
framework code will have filtered the Nodes before passing them to
provider-GCP. But this logic meant we added them anyway, sending
unintended traffic to the control plane machines.
@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e1fabd24-f09a-4719-ad00-c3ce87699655

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from nrb and theobarberbany September 1, 2026 14:04
@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nrb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: Jira Issue OCPBUGS-99228 has been cloned as Jira Issue OCPBUGS-115261. Will retitle bug to link to clone.
/retitle [release-4.21] OCPBUGS-115261: Fix node.kubernetes.io/exclude-from-external-load-balancers on masters

Details

In response to this:

This is an automated cherry-pick of #130

/assign openshift-cherrypick-robot

/cherrypick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.21] OCPBUGS-99228: Fix node.kubernetes.io/exclude-from-external-load-balancers on masters [release-4.21] OCPBUGS-115261: Fix node.kubernetes.io/exclude-from-external-load-balancers on masters Sep 1, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 1, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-115261, which is invalid:

  • expected dependent Jira Issue OCPBUGS-99228 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #130

/assign openshift-cherrypick-robot

/cherrypick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit d79d0e8 link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants