Repository navigation
Harden credential cleanup fixture and qualify CLI RC3 publication - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux source admission can exhaust the credential fixture's 300 ms bound before its escaped-child PID is recorded. The test then reads an empty PID and probes
/proc/stat, reporting global CPU statistics as a surviving descendant. Publish the complete PID atomically before unrelated argv/environment logging, read the newline-free mode with shell builtins, and require a nonzero numeric PID before probing procfs.Preserve the 300 ms call bound, three-second completion bound, credential-unavailable result, and killed-or-zombie assertion. Missing PID remains an explicit fixture failure. Only the Linux
#[cfg(test)]module changes; production regions are byte-identical. Local shell controls cover normal setup and an injected slow unrelated prelude; Linux Rust CI remains authoritative. Independent read-only diagnosis/repair review agrees.This supersedes release-plan PR47 and carries its unchanged qualified CLI 0.15.0-rc.3 plan. Frozen source
1941a34, native archives and two accepted live attempts remain unchanged; all four exact native/Homebrew gates and original final-main qualification passed. Fresh USD 20 reservation is closed, actual billing unknown, no paid retry. The original PR47 source failure remains retained. No production cleanup fix, Apple signing, stable/latest, default alias or kernel promotion claim. Merge/publication require all substantive exact-head checks passing.