Conversation
This was referenced Sep 29, 2026
Contributor
|
The existing symlink isn't really a "duplicated" asset. Replacing it with copying and cleanup adds complexity without addressing a demonstrated problem, so I'd prefer to retain the symlink. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up shared-DAGMC-data cleanup for #4093.
The external C++ DAGMC regression test stores another copy of the legacy
dagmc.h5m, even though the canonical geometry already lives attests/regression_tests/dagmc/legacy/dagmc.h5m.The C++ driver calls
load_file("dagmc.h5m")directly, so this keeps that runtime contract unchanged: a fixture copies the canonical geometry beside the driver for the duration of the test and removes it afterward. The duplicate checked-in asset is then removed.No production code changes.
Validation at
7a83e9227b9bbdd17f63e1e6f568ad513ceb9769:develop, 0 behindFork validation: kvnloo#6
AI-assisted source review and implementation.