Skip to content

test: stage canonical DAGMC geometry for external driver - #6

Closed
kvnloo wants to merge 2 commits into
developfrom
test/external-dagmc-canonical-asset
Closed

kvnloo wants to merge 2 commits into
developfrom
test/external-dagmc-canonical-asset

Conversation

@kvnloo

@kvnloo kvnloo commented Sep 29, 2026 •

Copy link
Copy Markdown
Owner

Promoted upstream

Canonical review path: openmc-dev#4153

This fork PR is closed to leave one review path. Its green CI remains the validation record for the exact promoted head.


Fork-only shared-test-data cleanup related to openmc-dev#4093. Not an upstream review request yet.

Scope

  • stop storing a duplicate dagmc.h5m beside the external C++ DAGMC regression driver;
  • copy the canonical legacy geometry from tests/regression_tests/dagmc/legacy/dagmc.h5m into the driver's working directory for the duration of the test;
  • clean it up afterward.

The C++ driver still calls load_file("dagmc.h5m"), so its runtime behavior is preserved.

No production code changes.

Validation target

Based on current upstream develop at 3cded0fb. Fork CI is the gate before promotion.

AI-assisted source review and implementation.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 36539346083

Coverage increased (+0.005%) to 81.39%

Details

  • Coverage increased (+0.005%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 72325
Covered Lines: 62563
Line Coverage: 86.5%
Relevant Branches: 29211
Covered Branches: 20077
Branch Coverage: 68.73%
Branches in Coverage %: Yes
Coverage Strength: 42758997.08 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants