chore: refresh CrawlKit and Chinese tokenizer dependencies - #234
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. Reviewed September 13, 2026, 11:52 AM ET / 15:52 UTC. ClawSweeper reviewWhat this changesUpdates CrawlKit and the optional Chinese tokenizer dependencies while preserving Discrawl’s Go requirements and SQLite dependency pairing. Merge readiness⛔ Blocked before merge - 2 items remain Keep open: the refresh is not on main or in v0.15.0, and no concrete patch defect was found. Real behavior proof remains the merge blocker. Priority: P3 Review scores
Verification
How this fits togetherDiscrawl archives Discord messages locally and exposes search through its CLI. CrawlKit supplies shared archive utilities; the optional Chinese helper converts messages and queries into terms for lexical search. flowchart LR
A[Discord messages] --> B[Discrawl archive]
C[CrawlKit utilities] --> B
B --> D[Chinese tokenizer helper]
E[Search query] --> D
D --> F[Lexical index and search]
F --> G[CLI results]
Before merge
Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Retain the focused dependency refresh and existing helper-rebuild procedure, with observed archive and Chinese search results confirming compatibility. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR refreshes dependencies rather than reporting a reproducible bug; no runtime commands were executed during this read-only review. Is this the best way to solve the issue? Yes: updating existing pins is a narrow approach, and the consumed APIs, Go requirements, and documented helper upgrade path remain intact. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against 0701225990c4. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
What Problem This Solves
Refresh the remaining outdated dependencies in Discrawl and its optional Chinese lexical helper.
User Impact
Updates CrawlKit from v0.16.1 to v0.16.2, gse from v1.0.2 to v1.1.0, cedar from v0.30.0 to v0.50.0, and the helper's transitive test dependency tt from v0.20.1 to v0.40.0. Existing Go minimums and CLI behavior are preserved.
Why This Change Was Made
The root module and all three helper modules were checked, along with toolchains, analysis tools, GitHub Actions, release tooling, and Docker inputs. The remaining pins are current. SQLite v1.58.0 explicitly requires libc v1.75.6, so libc v1.75.7 is held. Charm v2 requires a CrawlKit-owned migration and remains outside this dependency refresh. Modules used only by dependencies' own tests/tools are left to their owners rather than adding unused root requirements.
Evidence
Validated head:
6d268929fa0fb6e5cefeb6fe6db323667d73a582.go mod download,go mod verify, andgo mod tidy; SHA-256 hashes of all eightgo.mod/go.sumfiles stayed unchanged. Builds useGOFLAGS=-mod=readonly.wiretapimported a synthetic cached DM into a disposable SQLite archive;search --dm,status, SQL count,dms, andtui --dm --jsonreturned the expected data. No real Discord archive or credentials were used.No application version bump, release, tag, or manual deployment.