chore: update Crawlkit to v0.16.3 - #237
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed September 14, 2026, 3:12 PM ET / 19:12 UTC (Revision 2). ClawSweeper reviewWhat this changesUpdates Discrawl’s shared Crawlkit library to v0.16.3, refreshes dependency checksums, and records the upgrade in the changelog. Merge readiness✅ Ready for maintainer review The upgrade remains useful and has no identified blocking defect. The added verification addresses the earlier review concern; current main still uses v0.16.2. Priority: P3 Review scores
Verification
How this fits togetherDiscrawl archives Discord messages for local search and terminal browsing. Crawlkit supplies shared archive, configuration, embedding, and remote-access components used by those workflows. flowchart LR
A[Discord messages] --> B[Discrawl capture]
B --> C[Local archive]
D[Crawlkit library] --> C
D --> E[Embedding providers]
C --> E
C --> F[Search and terminal browsing]
E --> F
Before mergeNone. Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Consume the published maintenance release while preserving Discrawl’s existing configuration, archive format, and runtime dependency pairing. Do we have a high-confidence way to reproduce the issue? Not applicable: this is dependency maintenance, and the PR explicitly avoids claiming that Crawlkit’s custom-client timeout defect reproduces in Discrawl. Is this the best way to solve the issue? Yes: updating the published module pin and corresponding checksums is the narrowest integration path; application changes are unnecessary. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against ae7fa0ff9b50. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
What Problem This Solves
Discrawl is one maintenance release behind its shared Crawlkit dependency.
User Impact
Builds use Crawlkit v0.16.3 while retaining the existing Go requirement, SQLite/libc versions, and configuration.
Why This Change Was Made
Adopt the v0.16.3 maintenance release through the module pin and refreshed checksums. No application code changes are needed. The custom-client embedding timeout fix is not presented as a reproduced Discrawl bug: its provider construction uses the default client.
Evidence
Module verification/tidiness, formatting, lint, vet, staticcheck, gosec, and govulncheck passed (no reachable vulnerabilities). Snapshot builds passed for macOS, Linux, and Windows on amd64 and arm64. Structured autoreview returned no findings. A signed native build reads the existing archive status successfully.
Full race/coverage tests and CLI smoke passed, with 85.9% coverage. The local race run used
GIT_CONFIG_NOSYSTEM=1 GIT_CONFIG_GLOBAL=/dev/null: an existing publication fixture fails with macOS systeminit.defaultBranch=mainon both v0.16.2 and v0.16.3; isolating Git settings makes it pass. No fixture or application change was added for that pre-existing condition.The signed macOS build was deployed locally with the same designated signing identity and executable path. Native capture and live embeddings resumed, startup repair completed, and no failed or pending embedding jobs remained. Configuration and archive schema were unchanged.
Dependency reorganization verification
Read both complete module sources locally to cover the dependency-source access gap in the initial ClawSweeper review. A Go parser/token comparison found all 187 remote declarations and all 91 snapshot declarations unchanged, apart from file placement/comments. TUI retained 355 declarations unchanged; the remaining 47 changes preserve function signatures and reduce to integer min/max builtins plus inlining an always-newest sort helper. Thirteen obsolete unexported helpers were removed.
Additionally,
GIT_CONFIG_NOSYSTEM=1 GIT_CONFIG_GLOBAL=/dev/null GOWORK=off GOFLAGS=-mod=readonly go test -count=1 -race ./remote ./snapshot ./tui ./embed ./configpassed from the published Crawlkit v0.16.3 module. The source check and package tests cover the reorganized code; this does not claim live cloud integration or interactive TUI acceptance.The earlier draft/test reminder is also resolved: this PR is ready, the full Discrawl race/coverage suite passed locally, and the GitHub test job passed on this head.