Skip to content

Handle quoted authentication URLs #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mldangelo-oai merged 1 commit into from
Jul 31, 2026
+3 −3
Merged

Handle quoted authentication URLs #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/typescript/src/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ export async function runCodex(

function preferredAuthUrl(value: string): string | null {
for (const match of plainTerminalText(value).matchAll(
/https?:\/\/[^\s<>]+/g,
/https?:\/\/[^\s<>"']+/g,
)) {
const url = match[0].replace(/[.,;:!?)\]}]+$/, "");
try {
Expand Down
4 changes: 2 additions & 2 deletions sdk/typescript/tests-ts/auth.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ if (args.join(" ") === "login --with-api-key") {
console.error("Listening on http://[::ffff:127.0.0.1]:1455.");
console.error("Listening on http://[::ffff:0.0.0.0]:1455.");
console.error("Listening on http://[::127.0.0.1]:1455.");
console.error("Open \\u001b[32mhttps://127.auth.example.test/device\\u001b[0m");
console.error('Open "\\u001b[32mhttps://127.auth.example.test/device\\u001b[0m"');
console.error("Enter this one-time code");
console.error("\\u001b[36m8356-V2EGR\\u001b[0m");
process.exit(0);
Expand Down Expand Up @@ -167,7 +167,7 @@ setInterval(() => {}, 1000);
await expect(logout(command, process.env)).resolves.toBeUndefined();
});

test("captures interactive login metadata and completion", async () => {
test("captures quoted interactive login metadata and completion", async () => {
const command = await fakeCodex();
let succeeded = false;
const handle = new CodexLoginHandle(
Expand Down
Loading