Handle quoted authentication URLs - #179
Merged
mldangelo-oai merged 1 commit intoJul 31, 2026
Merged
Conversation
dipeshbabu
force-pushed
the
agent/handle-quoted-auth-urls
branch
from
July 31, 2026 09:52
38f591c to
fdd9a56
Compare
mldangelo-oai
approved these changes
Jul 31, 2026
mldangelo-oai
left a comment
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed exact head fdd9a56. Quoted and ANSI-decorated authentication URLs are handled correctly; focused authentication tests, additional quote/ANSI compatibility cases, TypeScript checks, and formatting pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The terminal URL matcher allowed quote characters inside a matched token. When Codex printed a verification URL in quotes, the closing quote was retained and became part of the returned URL path.
Impact
Interactive login callers now receive the exact verification URL when terminal output wraps it in quotes.
Overlap check
Searched open issues and pull requests for quoted authentication URLs, device-auth URL quoting, and the affected helper name; no overlapping work was found.
Validation
pnpm dlx bun test --timeout 30000 ./tests-ts/auth.test.ts(16 passed, 1 platform skip)pnpm exec tsc --noEmitpnpm exec prettier --check src/auth.ts tests-ts/auth.test.tsgit diff --cached --check