Initial prototype for dependencies in forge schema. - #1671
Open
jsuereth wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1671 +/- ##
=====================================
Coverage 81.4% 81.4%
=====================================
Files 131 131
Lines 11715 11748 +33
=====================================
+ Hits 9543 9571 +28
- Misses 2172 2177 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lmolkova
reviewed
Aug 7, 2026
jsuereth
marked this pull request as ready for review
August 7, 2026 20:43
Pull request dashboard statusWaiting on the author · refreshed 2026-08-08 00:39 UTC Respond to 2 review items (e.g. link a commit, explain why not, ask a follow-up): Status above doesn't look right?
|
lmolkova
reviewed
Aug 8, 2026
| "description": "A resolved semantic convention registry used in the context of the template and policy\nengines.\n\nThis includes all registries fully fleshed out and ready for codegen.", | ||
| "type": "object", | ||
| "properties": { | ||
| "dependencies": { |
Member
There was a problem hiding this comment.
please update md doc we have next to this file
| weaver_forge::v2::registry::ForgeResolvedRegistry::try_from_resolved_schema( | ||
| resolved.clone(), | ||
| )?; | ||
| let template = match weaver_forge::v2::registry::ForgeResolvedRegistry::try_from_resolved_schema( |
Member
There was a problem hiding this comment.
can you please add some tests? Mostly interested in having some existing test registry her, rendering its forge schema and having expected output checked in
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation of adding dependencies to forge schema.