Live-check: multi-registry v2 attribute lookup - #1665
Draft
jerbly wants to merge 4 commits into
Draft
Conversation
Pull request dashboard statusWaiting on the author · refreshed 2026-08-04 02:01 UTC Move out of draft to request review. Status above doesn't look right?
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1665 +/- ##
=====================================
Coverage 81.4% 81.4%
=====================================
Files 131 131
Lines 11714 11763 +49
=====================================
+ Hits 9538 9585 +47
- Misses 2176 2178 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1658
Fix 1 - always use the matched signal's attribute definitions first
Fix 2 - use the dependency registries to find attribute definitions when #1671 lands