Skip to content

Live-check: multi-registry v2 attribute lookup - #1665

Draft
jerbly wants to merge 4 commits into
open-telemetry:mainfrom
jerbly:fix-live-check-missing-attributes
Draft

Live-check: multi-registry v2 attribute lookup#1665
jerbly wants to merge 4 commits into
open-telemetry:mainfrom
jerbly:fix-live-check-missing-attributes

Conversation

@jerbly

@jerbly jerbly commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Fixes #1658

Fix 1 - always use the matched signal's attribute definitions first
Fix 2 - use the dependency registries to find attribute definitions when #1671 lands

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Aug 4, 2026

Copy link
Copy Markdown

Pull request dashboard status

Waiting on the author · refreshed 2026-08-04 02:01 UTC

Move out of draft to request review.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.4%. Comparing base (f7b63a0) to head (351a468).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_live_check/src/lib.rs 80.0% 6 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1665   +/-   ##
=====================================
  Coverage   81.4%   81.4%           
=====================================
  Files        131     131           
  Lines      11714   11763   +49     
=====================================
+ Hits        9538    9585   +47     
- Misses      2176    2178    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attribute Resolution Issues

1 participant