Skip to content

fix(ci): nightly workflow running stale project getting failed [skip-ci] #27849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chirag-madlani wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −20
Open

fix(ci): nightly workflow running stale project getting failed [skip-ci] #27849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions .github/workflows/mysql-nightly-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,21 +88,14 @@ jobs:
--project=DataAssetRulesEnabled \
--project=DataAssetRulesDisabled

elif [ "${{ matrix.shardIndex }}" -eq "6" ]; then
echo "🔹 Running stateful Playwright tests serially on shard 6"
npx playwright test \
--project=stateful \
--workers=1

else
# Shards 2-5 handle chromium tests (4 shards total)
# Shards 2-6 handle chromium tests (5 shards total)
CHROMIUM_SHARD=$(( ${{ matrix.shardIndex }} - 1 ))
echo "🔹 Running all tests (excluding DataAssetRules/stateful) on chromium shard ${CHROMIUM_SHARD}/4"
echo "🔹 Running all tests (excluding DataAssetRules) on chromium shard ${CHROMIUM_SHARD}/5"
npx playwright test \
--project=chromium \
--grep-invert @dataAssetRules \
--shard=${CHROMIUM_SHARD}/4 \
--workers=50%
--shard=${CHROMIUM_SHARD}/5
fi

env:
Expand Down
13 changes: 3 additions & 10 deletions .github/workflows/postgresql-nightly-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,21 +88,14 @@ jobs:
--project=DataAssetRulesEnabled \
--project=DataAssetRulesDisabled

elif [ "${{ matrix.shardIndex }}" -eq "6" ]; then
echo "🔹 Running stateful Playwright tests serially on shard 6"
npx playwright test \
--project=stateful \
--workers=1

else
# Shards 2-5 handle chromium tests (4 shards total)
# Shards 2-5 handle chromium tests (5 shards total)
Copy link
Copy Markdown

@gitar-bot gitar-bot Bot Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Bug: PostgreSQL workflow comment says "Shards 2-5" instead of "2-6"

The MySQL workflow correctly comments # Shards 2-6 handle chromium tests (5 shards total), but the PostgreSQL workflow says # Shards 2-5 handle chromium tests (5 shards total). Since shardIndex is [1, 2, 3, 4, 5, 6] and shard 1 handles DataAssetRules, chromium shards are indices 2 through 6 — the comment in the PostgreSQL file is incorrect and could confuse future maintainers.

Suggested fix:

Change the comment to match the MySQL file:
# Shards 2-6 handle chromium tests (5 shards total)

Was this helpful? React with 👍 / 👎 | Reply gitar fix to apply this suggestion

CHROMIUM_SHARD=$(( ${{ matrix.shardIndex }} - 1 ))
echo "🔹 Running all tests (excluding DataAssetRules/stateful) on chromium shard ${CHROMIUM_SHARD}/4"
echo "🔹 Running all tests (excluding DataAssetRules) on chromium shard ${CHROMIUM_SHARD}/5"
npx playwright test \
--project=chromium \
--grep-invert @dataAssetRules \
--shard=${CHROMIUM_SHARD}/4 \
--workers=50%
--shard=${CHROMIUM_SHARD}/5
fi

env:
Expand Down
Loading