Skip to content

fix(ci): nightly workflow running stale project getting failed [skip-ci]#27849

Open
chirag-madlani wants to merge 1 commit intomainfrom
fix-nightly-playwright-workflow
Open

fix(ci): nightly workflow running stale project getting failed [skip-ci]#27849
chirag-madlani wants to merge 1 commit intomainfrom
fix-nightly-playwright-workflow

Conversation

@chirag-madlani
Copy link
Copy Markdown
Collaborator

This pull request updates the Playwright test sharding configuration in both the MySQL and PostgreSQL nightly end-to-end workflow files. The main change is the removal of the dedicated stateful test shard and redistribution of Chromium tests across more shards for improved parallelism.

Test workflow improvements:

  • Removed the separate shard for running stateful Playwright tests serially, so these tests are no longer isolated to their own shard. (.github/workflows/mysql-nightly-e2e.yml, .github/workflows/postgresql-nightly-e2e.yml) [1] [2]
  • Increased the number of Chromium test shards from 4 to 5, redistributing the workload and updating related log messages and sharding parameters accordingly. (.github/workflows/mysql-nightly-e2e.yml, .github/workflows/postgresql-nightly-e2e.yml) [1] [2]
  • Removed the explicit --workers=50% parameter for Chromium shards, relying on the default worker configuration. (.github/workflows/mysql-nightly-e2e.yml, .github/workflows/postgresql-nightly-e2e.yml) [1] [2]

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copilot AI review requested due to automatic review settings April 30, 2026 15:00
@github-actions github-actions Bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Apr 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the nightly Playwright E2E GitHub Actions workflows (MySQL and PostgreSQL) to remove a stale/unused stateful Playwright project shard and rebalance Chromium test execution across more shards for improved parallelism.

Changes:

  • Removed the dedicated “stateful tests” shard and its --project=stateful invocation.
  • Increased Chromium sharding from 4 → 5 shards by adjusting shard math and logging.
  • Dropped the explicit --workers=50% override for Chromium shards.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/mysql-nightly-e2e.yml Removes the stateful shard and redistributes Chromium tests across 5 shards (shards 2–6).
.github/workflows/postgresql-nightly-e2e.yml Removes the stateful shard and redistributes Chromium tests across 5 shards; one shard-range comment needs alignment with the matrix.


else
# Shards 2-5 handle chromium tests (4 shards total)
# Shards 2-5 handle chromium tests (5 shards total)

else
# Shards 2-5 handle chromium tests (4 shards total)
# Shards 2-5 handle chromium tests (5 shards total)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Bug: PostgreSQL workflow comment says "Shards 2-5" instead of "2-6"

The MySQL workflow correctly comments # Shards 2-6 handle chromium tests (5 shards total), but the PostgreSQL workflow says # Shards 2-5 handle chromium tests (5 shards total). Since shardIndex is [1, 2, 3, 4, 5, 6] and shard 1 handles DataAssetRules, chromium shards are indices 2 through 6 — the comment in the PostgreSQL file is incorrect and could confuse future maintainers.

Suggested fix:

Change the comment to match the MySQL file:
# Shards 2-6 handle chromium tests (5 shards total)

Was this helpful? React with 👍 / 👎 | Reply gitar fix to apply this suggestion

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 30, 2026

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Updates the nightly CI workflow to target the correct project version, preventing stale build failures. Update the PostgreSQL workflow comment to reflect the correct shard count (2-6) for consistency with the MySQL workflow.

💡 Bug: PostgreSQL workflow comment says "Shards 2-5" instead of "2-6"

📄 .github/workflows/postgresql-nightly-e2e.yml:92

The MySQL workflow correctly comments # Shards 2-6 handle chromium tests (5 shards total), but the PostgreSQL workflow says # Shards 2-5 handle chromium tests (5 shards total). Since shardIndex is [1, 2, 3, 4, 5, 6] and shard 1 handles DataAssetRules, chromium shards are indices 2 through 6 — the comment in the PostgreSQL file is incorrect and could confuse future maintainers.

Suggested fix
Change the comment to match the MySQL file:
# Shards 2-6 handle chromium tests (5 shards total)
🤖 Prompt for agents
Code Review: Updates the nightly CI workflow to target the correct project version, preventing stale build failures. Update the PostgreSQL workflow comment to reflect the correct shard count (2-6) for consistency with the MySQL workflow.

1. 💡 Bug: PostgreSQL workflow comment says "Shards 2-5" instead of "2-6"
   Files: .github/workflows/postgresql-nightly-e2e.yml:92

   The MySQL workflow correctly comments `# Shards 2-6 handle chromium tests (5 shards total)`, but the PostgreSQL workflow says `# Shards 2-5 handle chromium tests (5 shards total)`. Since `shardIndex` is `[1, 2, 3, 4, 5, 6]` and shard 1 handles DataAssetRules, chromium shards are indices 2 through 6 — the comment in the PostgreSQL file is incorrect and could confuse future maintainers.

   Suggested fix:
   Change the comment to match the MySQL file:
   # Shards 2-6 handle chromium tests (5 shards total)

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants