fix(ci): nightly workflow running stale project getting failed [skip-ci]#27849
fix(ci): nightly workflow running stale project getting failed [skip-ci]#27849chirag-madlani wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the nightly Playwright E2E GitHub Actions workflows (MySQL and PostgreSQL) to remove a stale/unused stateful Playwright project shard and rebalance Chromium test execution across more shards for improved parallelism.
Changes:
- Removed the dedicated “stateful tests” shard and its
--project=statefulinvocation. - Increased Chromium sharding from 4 → 5 shards by adjusting shard math and logging.
- Dropped the explicit
--workers=50%override for Chromium shards.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/mysql-nightly-e2e.yml | Removes the stateful shard and redistributes Chromium tests across 5 shards (shards 2–6). |
| .github/workflows/postgresql-nightly-e2e.yml | Removes the stateful shard and redistributes Chromium tests across 5 shards; one shard-range comment needs alignment with the matrix. |
|
|
||
| else | ||
| # Shards 2-5 handle chromium tests (4 shards total) | ||
| # Shards 2-5 handle chromium tests (5 shards total) |
|
|
||
| else | ||
| # Shards 2-5 handle chromium tests (4 shards total) | ||
| # Shards 2-5 handle chromium tests (5 shards total) |
There was a problem hiding this comment.
💡 Bug: PostgreSQL workflow comment says "Shards 2-5" instead of "2-6"
The MySQL workflow correctly comments # Shards 2-6 handle chromium tests (5 shards total), but the PostgreSQL workflow says # Shards 2-5 handle chromium tests (5 shards total). Since shardIndex is [1, 2, 3, 4, 5, 6] and shard 1 handles DataAssetRules, chromium shards are indices 2 through 6 — the comment in the PostgreSQL file is incorrect and could confuse future maintainers.
Suggested fix:
Change the comment to match the MySQL file:
# Shards 2-6 handle chromium tests (5 shards total)
Was this helpful? React with 👍 / 👎 | Reply gitar fix to apply this suggestion
Code Review 👍 Approved with suggestions 0 resolved / 1 findingsUpdates the nightly CI workflow to target the correct project version, preventing stale build failures. Update the PostgreSQL workflow comment to reflect the correct shard count (2-6) for consistency with the MySQL workflow. 💡 Bug: PostgreSQL workflow comment says "Shards 2-5" instead of "2-6"📄 .github/workflows/postgresql-nightly-e2e.yml:92 The MySQL workflow correctly comments Suggested fix🤖 Prompt for agentsOptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
This pull request updates the Playwright test sharding configuration in both the MySQL and PostgreSQL nightly end-to-end workflow files. The main change is the removal of the dedicated stateful test shard and redistribution of Chromium tests across more shards for improved parallelism.
Test workflow improvements:
--workers=50%parameter for Chromium shards, relying on the default worker configuration. (.github/workflows/mysql-nightly-e2e.yml, .github/workflows/postgresql-nightly-e2e.yml) [1] [2]Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>