Skip to content

Chore(UI): Add test.slow() to customProperties spec to cover for slow responses in AUT runs#27782

Merged
aniketkatkar97 merged 3 commits intomainfrom
customProperty-flaky
Apr 28, 2026
Merged

Chore(UI): Add test.slow() to customProperties spec to cover for slow responses in AUT runs#27782
aniketkatkar97 merged 3 commits intomainfrom
customProperty-flaky

Conversation

@aniketkatkar97
Copy link
Copy Markdown
Member

@aniketkatkar97 aniketkatkar97 commented Apr 28, 2026

This pull request marks several Playwright tests as "slow" in the CustomProperties.spec.ts file. This helps the test runner handle potentially long-running tests more gracefully, reducing the chance of false negatives due to timeouts.

The most important changes are:

Test Stability Improvements:

  • Added test.slow(); to basic property tests to indicate they may take longer to execute.
  • Marked entity reference list custom property tests as slow for better timeout handling.

Hyperlink Custom Property Tests:

  • Marked multiple hyperlink-related tests as slow, including checks for "No Data" placeholders, XSS protection, valid URL acceptance, and display behavior. [1] [2] [3] [4]

Table Custom Property Tests:

  • Marked table custom property tests (Name, Role, and Sr No columns with all operators) as slow to ensure reliable execution. [1] [2] [3]

Summary by Gitar

  • Test configuration:
    • Replaced test.slow(true) with an explicit 5-minute timeout via test.setTimeout(300000) in CustomProperties.spec.ts.

This will update automatically on new commits.

@aniketkatkar97 aniketkatkar97 self-assigned this Apr 28, 2026
Copilot AI review requested due to automatic review settings April 28, 2026 07:29
@aniketkatkar97 aniketkatkar97 requested a review from a team as a code owner April 28, 2026 07:29
@github-actions github-actions Bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Apr 28, 2026
@aniketkatkar97 aniketkatkar97 added the To release Will cherry-pick this PR into the release branch label Apr 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves Playwright E2E stability for Custom Properties by marking several long-running tests as slow, giving them extended timeouts during execution (notably for AUT runs where responses can be slower).

Changes:

  • Marked basic CRUD custom property tests as slow.
  • Marked entityReferenceList-related custom property tests as slow.
  • Marked hyperlink and table custom property tests as slow to reduce timeout-related flakes.

chirag-madlani
chirag-madlani previously approved these changes Apr 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

🟡 Playwright Results — all passed (13 flaky)

✅ 3962 passed · ❌ 0 failed · 🟡 13 flaky · ⏭️ 86 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 298 0 1 4
🟡 Shard 2 742 0 3 8
🟡 Shard 3 746 0 2 7
✅ Shard 4 759 0 0 18
🟡 Shard 5 684 0 3 41
🟡 Shard 6 733 0 4 8
🟡 13 flaky test(s) (passed on retry)
  • Features/CustomizeDetailPage.spec.ts › Data Product - customization should work (shard 1, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event is created when description is updated (shard 2, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event shows the actor who made the change (shard 2, 1 retry)
  • Features/IncidentManager.spec.ts › Complete Incident lifecycle with table owner (shard 2, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
  • Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 5, 1 retry)
  • Pages/EntityDataConsumer.spec.ts › Tier Add, Update and Remove (shard 5, 1 retry)
  • Pages/EntityDataConsumer.spec.ts › Tier Add, Update and Remove (shard 5, 1 retry)
  • Pages/Glossary.spec.ts › Async Delete - multiple deletes with mixed results (shard 6, 1 retry)
  • Pages/Glossary.spec.ts › Glossary Term Update in Glossary Page should persist tree (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Copilot AI review requested due to automatic review settings April 28, 2026 12:05
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 28, 2026

Code Review ✅ Approved

Increases timeout threshold for customProperties spec using test.slow() to accommodate sluggish response times during automated runs. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
62.09% (62240/100235) 42.27% (33363/78923) 45.32% (9891/21823)

@sonarqubecloud
Copy link
Copy Markdown

@aniketkatkar97 aniketkatkar97 merged commit a1e7086 into main Apr 28, 2026
50 checks passed
@aniketkatkar97 aniketkatkar97 deleted the customProperty-flaky branch April 28, 2026 14:27
@github-actions
Copy link
Copy Markdown
Contributor

Failed to cherry-pick changes to the 1.12.7 branch.
Please cherry-pick the changes manually.
You can find more details here.

aniketkatkar97 added a commit that referenced this pull request Apr 28, 2026
… responses in AUT runs (#27782)

* Add test.slow() to customProperties spec to cover for slow responses in AUT runs

* Increase the timeout for custom properties common test as well
aniketkatkar97 added a commit that referenced this pull request Apr 28, 2026
… responses in AUT runs (#27782)

* Add test.slow() to customProperties spec to cover for slow responses in AUT runs

* Increase the timeout for custom properties common test as well
jatinmasaram pushed a commit to jatinmasaram/OpenMetadata that referenced this pull request May 2, 2026
… responses in AUT runs (open-metadata#27782)

* Add test.slow() to customProperties spec to cover for slow responses in AUT runs

* Increase the timeout for custom properties common test as well
jaya6400 pushed a commit to jaya6400/OpenMetadata that referenced this pull request May 4, 2026
… responses in AUT runs (open-metadata#27782)

* Add test.slow() to customProperties spec to cover for slow responses in AUT runs

* Increase the timeout for custom properties common test as well
siddhant1 added a commit that referenced this pull request May 4, 2026
…ver slow responses in 1.13 AUT runs (#27885)

The test consistently lands at the 60s test-timeout boundary on 1.13 AUT
(image n56+) where the backend CSV-import flow takes ~50s end-to-end —
matching the precedent set by #27782 for customProperties. test.slow()
triples the timeout to 180s so transient AUT jitter no longer flakes the
test.

Co-authored-by: Siddhant <siddhant@MacBook-Pro-621.local>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants