Skip to content

Chore(UI): test.slow() for CSVImportWithQuotesAndCommas to cover 1.13 AUT timing#27885

Merged
siddhant1 merged 1 commit into1.13from
sid/1.13-csv-debug
May 4, 2026
Merged

Chore(UI): test.slow() for CSVImportWithQuotesAndCommas to cover 1.13 AUT timing#27885
siddhant1 merged 1 commit into1.13from
sid/1.13-csv-debug

Conversation

@siddhant1
Copy link
Copy Markdown
Member

Summary

Why

On 1.13 AUT, the CSV-import end-to-end flow consistently lands at ~48–52s — right at the 60s test-timeout boundary — and times out under any extra cluster jitter. Walking the recent run history:

Image First attempt Retry #1
n55 (Apr 28) ✘ 30.9s ✘ 28.1s
n56 (Apr 29) ✘ 48.9s ✘ 51.3s
n67 (May 3) ✘ 1.0m ✓ 52.4s
n70 (May 4) ✘ 1.0m ✘ 1.0m

Same test on regular (non-AUT) 1.13 Playwright passes in ~24s, and the same test on main AUT (run 25235690014, May 1) passes in 37.4s. The slow path is specific to 1.13 AUT (legacy task/feed system + bounded-executor backpressure under upgrade-loaded sample data).

test.slow() is the unblocker; the underlying backend latency is a separate investigation.

Test plan

  • Re-run the AUT MySQL 1.9.1 ➡ 1.13 workflow and confirm CSV Import with Commas and Quotes - All Entity Types › Create glossary with CSV, export it, create new glossary and import exported data passes within the new 180s budget.
  • Verify regular 1.13 Playwright runs still pass (no behavior change for the fast path).

🤖 Generated with Claude Code

…ver slow responses in 1.13 AUT runs

The test consistently lands at the 60s test-timeout boundary on 1.13 AUT
(image n56+) where the backend CSV-import flow takes ~50s end-to-end —
matching the precedent set by #27782 for customProperties. test.slow()
triples the timeout to 180s so transient AUT jitter no longer flakes the
test.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@siddhant1 siddhant1 requested a review from a team as a code owner May 4, 2026 11:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@siddhant1 siddhant1 added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels May 4, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 4, 2026

Code Review ✅ Approved

Increases the timeout for CSVImportWithQuotesAndCommas to 180s via test.slow() to accommodate timing jitter in 1.13 AUT runs. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@siddhant1 siddhant1 merged commit 149e443 into 1.13 May 4, 2026
57 of 92 checks passed
@siddhant1 siddhant1 deleted the sid/1.13-csv-debug branch May 4, 2026 11:56
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

🟡 Playwright Results — all passed (14 flaky)

✅ 3714 passed · ❌ 0 failed · 🟡 14 flaky · ⏭️ 79 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 290 0 0 4
🟡 Shard 2 695 0 3 7
🟡 Shard 3 715 0 2 1
🟡 Shard 4 695 0 3 24
✅ Shard 5 673 0 0 35
🟡 Shard 6 646 0 6 8
🟡 14 flaky test(s) (passed on retry)
  • Features/ActivityFeed.spec.ts › emoji reactions can be added when feed messages exist (shard 2, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/Glossary/GlossaryMiscOperations.spec.ts › should delete glossary and remove tags from assets (shard 2, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
  • Pages/DataContractsSemanticRules.spec.ts › Validate Owner Rule Not_In (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Subdomain rename does not affect parent domain and updates nested children (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Multiple consecutive domain renames preserve all associations (shard 4, 1 retry)
  • Pages/Glossary.spec.ts › Column dropdown drag-and-drop functionality for Glossary Terms table (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab is NOT visible for databaseService in platform lineage (shard 6, 1 retry)
  • Pages/Lineage/PlatformLineage.spec.ts › Verify domain platform view (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants