-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(ui): keep policy rule operations in sync with server #27694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nehaaprasaad
wants to merge
1
commit into
open-metadata:main
Choose a base branch
from
nehaaprasaad:fix/view-bas-class
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
openmetadata-ui/src/main/resources/ui/src/utils/PolicyRuleUtils.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Copyright 2026 Collate. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { Operation } from '../generated/api/policies/createPolicy'; | ||
| import { filterRedundantPolicyOperations } from './PolicyRuleUtils'; | ||
|
|
||
| describe('PolicyRuleUtils', () => { | ||
| it('keeps ViewBasic when it is the only view operation', () => { | ||
| const result = filterRedundantPolicyOperations([Operation.ViewBasic]); | ||
| expect(result).toEqual([Operation.ViewBasic]); | ||
| }); | ||
|
|
||
| it('removes other view operations when ViewAll is present', () => { | ||
| const result = filterRedundantPolicyOperations([ | ||
| Operation.Create, | ||
| Operation.ViewAll, | ||
| Operation.ViewBasic, | ||
| Operation.ViewUsage, | ||
| ]); | ||
| expect(result).toEqual([Operation.Create, Operation.ViewAll]); | ||
| }); | ||
|
|
||
| it('does not remove view operations when ViewAll is absent', () => { | ||
| const result = filterRedundantPolicyOperations([ | ||
| Operation.Create, | ||
| Operation.ViewBasic, | ||
| Operation.ViewUsage, | ||
| ]); | ||
| expect(result).toEqual([ | ||
| Operation.Create, | ||
| Operation.ViewBasic, | ||
| Operation.ViewUsage, | ||
| ]); | ||
| }); | ||
| }); | ||
39 changes: 39 additions & 0 deletions
39
openmetadata-ui/src/main/resources/ui/src/utils/PolicyRuleUtils.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * Copyright 2026 Collate. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { Operation } from '../generated/api/policies/createPolicy'; | ||
|
|
||
| const isViewOperation = (operation: Operation) => operation.startsWith('View'); | ||
|
|
||
| const isEditOperation = (operation: Operation) => operation.startsWith('Edit'); | ||
|
|
||
| /** | ||
| * Matches server-side PolicyRepository.filterRedundantOperations so the policy | ||
| * rule editor stays consistent with stored policy rules. | ||
| */ | ||
| export const filterRedundantPolicyOperations = ( | ||
| operations: Operation[] | ||
| ): Operation[] => { | ||
| let result = [...operations]; | ||
| if (result.includes(Operation.ViewAll)) { | ||
| result = result.filter( | ||
| (o) => o === Operation.ViewAll || !isViewOperation(o) | ||
| ); | ||
| } | ||
| if (result.includes(Operation.EditAll)) { | ||
| result = result.filter( | ||
| (o) => o === Operation.EditAll || !isEditOperation(o) | ||
| ); | ||
| } | ||
| return result; | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Quality: Unit tests missing coverage for EditAll filtering path
The
PolicyRuleUtils.test.tsfile only testsViewAll/ViewBasicscenarios but has no test for theEditAllbranch offilterRedundantPolicyOperations. Since the function has two independent filter paths (ViewAll and EditAll), both should be exercised to prevent regressions.Suggested fix:
Was this helpful? React with 👍 / 👎 | Reply
gitar fixto apply this suggestion