fix(ui): keep policy rule operations in sync with server

[nehaaprasaad]

Describe your changes

fix : #27591

• Align policy rule operations in the UI with server filterRedundantOperations (PolicyRuleUtils + RuleForm + policy rule pages).
• IT: classification repro + ViewBasic-only regression.
• Tested: yarn test PolicyRuleUtils.test.ts

Type of change

• Bug fix

Checklist

[x] CONTRIBUTING
[x] Bug fix test (IT + unit)

[github-actions]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

[gitar-bot]

💡 Quality: Unit tests missing coverage for EditAll filtering path

The PolicyRuleUtils.test.ts file only tests ViewAll/ViewBasic scenarios but has no test for the EditAll branch of filterRedundantPolicyOperations. Since the function has two independent filter paths (ViewAll and EditAll), both should be exercised to prevent regressions.

Suggested fix:

Add tests for EditAll filtering, e.g.:

it('removes other edit operations when EditAll is present', () => {
  const result = filterRedundantPolicyOperations([
    Operation.ViewBasic,
    Operation.EditAll,
    Operation.EditDescription,
    Operation.EditTags,
  ]);
  expect(result).toEqual([Operation.ViewBasic, Operation.EditAll]);
});

it('handles both ViewAll and EditAll together', () => {
  const result = filterRedundantPolicyOperations([
    Operation.ViewAll,
    Operation.ViewBasic,
    Operation.EditAll,
    Operation.EditTags,
  ]);
  expect(result).toEqual([Operation.ViewAll, Operation.EditAll]);
});

_{Was this helpful? React with 👍 / 👎 | Reply gitar fix to apply this suggestion}

[gitar-bot]

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Synchronizes UI policy rule operations with server-side state for improved consistency. Add unit tests for the EditAll filtering path to ensure complete test coverage.

💡 Quality: Unit tests missing coverage for EditAll filtering path

📄 openmetadata-ui/src/main/resources/ui/src/utils/PolicyRuleUtils.test.ts:17-31

The PolicyRuleUtils.test.ts file only tests ViewAll/ViewBasic scenarios but has no test for the EditAll branch of filterRedundantPolicyOperations. Since the function has two independent filter paths (ViewAll and EditAll), both should be exercised to prevent regressions.

Suggested fix

Add tests for EditAll filtering, e.g.:

it('removes other edit operations when EditAll is present', () => {
  const result = filterRedundantPolicyOperations([
    Operation.ViewBasic,
    Operation.EditAll,
    Operation.EditDescription,
    Operation.EditTags,
  ]);
  expect(result).toEqual([Operation.ViewBasic, Operation.EditAll]);
});

it('handles both ViewAll and EditAll together', () => {
  const result = filterRedundantPolicyOperations([
    Operation.ViewAll,
    Operation.ViewBasic,
    Operation.EditAll,
    Operation.EditTags,
  ]);
  expect(result).toEqual([Operation.ViewAll, Operation.EditAll]);
});

🤖 Prompt for agents

Code Review: Synchronizes UI policy rule operations with server-side state for improved consistency. Add unit tests for the EditAll filtering path to ensure complete test coverage.

1. 💡 Quality: Unit tests missing coverage for EditAll filtering path
   Files: openmetadata-ui/src/main/resources/ui/src/utils/PolicyRuleUtils.test.ts:17-31

   The `PolicyRuleUtils.test.ts` file only tests `ViewAll`/`ViewBasic` scenarios but has no test for the `EditAll` branch of `filterRedundantPolicyOperations`. Since the function has two independent filter paths (ViewAll and EditAll), both should be exercised to prevent regressions.

   Suggested fix:
   Add tests for EditAll filtering, e.g.:
   
   it('removes other edit operations when EditAll is present', () => {
     const result = filterRedundantPolicyOperations([
       Operation.ViewBasic,
       Operation.EditAll,
       Operation.EditDescription,
       Operation.EditTags,
     ]);
     expect(result).toEqual([Operation.ViewBasic, Operation.EditAll]);
   });
   
   it('handles both ViewAll and EditAll together', () => {
     const result = filterRedundantPolicyOperations([
       Operation.ViewAll,
       Operation.ViewBasic,
       Operation.EditAll,
       Operation.EditTags,
     ]);
     expect(result).toEqual([Operation.ViewAll, Operation.EditAll]);
   });

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact

gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}