Conversation
…ow closes Three things only a Windows sender got wrong: - Link targets were recorded as `read_link` gave them, `..\shared\config`, which a Linux or macOS receiver takes as one name with backslashes in it. Relative targets are now written with `/`, and absolute ones, which would dangle on any other machine, are left out with a reason. - Closing the console window, logging off and shutting down are not Ctrl-C on Windows, and nothing handled them, so a compressed send's spool file (a copy of the user's data) stayed in %TEMP%. They now start the same cancel-and-clean path as Ctrl-C, as does Ctrl-Break. - The progress line assumed escape sequences work. The older console that cmd.exe still opens prints them literally until VT processing is turned on. It is turned on now, and where that fails the line is redrawn with padding instead. Also pinned on every platform: a spool file can be deleted while the chunk reader has it open, which on Windows depends on how the file was opened. The Windows-only code is compiled first by the Windows CI runner. Cross-platform plan, phase 2. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7Fy45hUvna94cd79WKG8S
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-platform plan, phase 2. Behaviour change, so it waits for your review. Stacked on #73.
..\shared\config, which Linux and macOS receivers read as a single name. Relative targets are now written with/. Absolute ones (C:\…,\\server\…) would dangle on any other machine, so they're left out, and the warning says why.TarPlan::skippednow carries a reason per entry.%TEMP%.\rplus space padding instead of printing←[2Kgarbage.Tests: 252. All
cfg(windows)code is compiled for the first time by the Windows CI runner, since this machine has no Windows target. It will first run in a real console during phase 5's manual checklist.🤖 Generated with Claude Code
https://claude.ai/code/session_01G7Fy45hUvna94cd79WKG8S