Conversation
The release workflow builds x86_64-pc-windows-msvc, and aarch64 on an Arm runner, as zips holding drop.exe. The C runtime is linked statically, so it starts on a machine without the Visual C++ redistributable. The Arm build is marked continue-on-error, since a toolchain problem there must not hold back a release. Checksums cover the zips, and install.ps1 is published beside install.sh. install.ps1 is the Windows counterpart of install.sh, with the same three variables. It verifies the checksum, installs to %LOCALAPPDATA%\Programs\drop, and adds that directory to the user's own PATH, without elevation. It runs in its own script block and fails with `throw`, because through `irm | iex` a bare `exit` would close the user's PowerShell window. install.sh run from Git Bash now points at it instead of saying the OS is unsupported. A new Installer CI job runs both installers for real on every pull request. It serves locally built packages laid out like a release, checks the installed binary runs, and checks that a tampered checksum is refused and installs nothing. install.ps1 runs under both pwsh 7 and Windows PowerShell 5. The Linux half was run locally. Cross-platform plan, phase 3. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7Fy45hUvna94cd79WKG8S
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
One Windows run of the installer job started install.ps1 before the local Python server was listening, and the download failed. Both halves of the job now poll the server until it answers. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7Fy45hUvna94cd79WKG8S
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-platform plan, phase 3. It changes the release workflow, so it needs your review. Stacked on #74.
Release
x86_64-pc-windows-msvc(windows-2025) andaarch64-pc-windows-msvc(windows-11-arm), packaged asdrop-<target>.zipcontainingdrop.exe,LICENSEandREADME.md.RUSTFLAGS=-C target-feature=+crt-static, Windows build step only), so drop.exe runs without the VC++ redistributable.continue-on-error.ringhas needed clang there before, and this can't block a release. Without that zip, Windows 11 on Arm runs the x86_64 build under emulation.checksums.txtcovers the zips;install.ps1is published besideinstall.sh.install.ps1irm https://github.com/op-q/drop/releases/latest/download/install.ps1 | iexDROP_VERSION,DROP_INSTALL_DIRandDROP_RELEASE_BASEvariables asinstall.sh.%LOCALAPPDATA%\Programs\drop, and adds that to the user PATH, without admin rights.& { }and errors usethrow. Underiex, a bareexitwould close the user's window, and preference variables would leak into their session.drop.exeis already there and running, the old one is renamed aside first, so an upgrade still works.install.shunder Git Bash/MSYS now points to the PowerShell installer instead of reporting an unsupported OS.Tested in CI (new
Installerjob)It builds the CLI, lays out packages exactly as a release does, serves them on loopback, and runs the real installers:
install.shinstalls a binary that runs, and a tampered checksum is refused and installs nothing. This half was also run locally and passes.install.ps1under both pwsh 7 and Windows PowerShell 5, plus the same tamper check.Not verified
drop.exeimports noVCRUNTIME140.dll. There's no reliabledumpbinon the runner's PATH; your clean-machine install during phase 5 will show it.README gains Windows install instructions, a platform table, and the known Windows limitations (renamed names, skipped symlinks, no executable bit, the firewall prompt).
🤖 Generated with Claude Code
https://claude.ai/code/session_01G7Fy45hUvna94cd79WKG8S