ASoC: re-lift guarded SP11 TX DMIC capture - #36
Conversation
WITHDRAWN: aggregate qualification candidateDo not install or hardware-test A final-tree comparison against the hardware-qualified This correction supersedes the build notice below; the old results are retained Historical aggregate build record (withdrawn)The held qualification branch
The #37/#38 registry overlap was combined without simplifying either feature: These are historical composition and packaging results, not hardware |
|
Aggregate hardware qualification is tracked in #41 at exact candidate This topic remains draft. A green aggregate build or CI result does not satisfy PR #41 is a test-only aggregate and must close without merge. |
|
Provenance audit: all three relift commits have matching Leon author sign-offs and retain their source links/dates. The divider and shared-clock commits also preserve geoca credit with |
58fec71 to
f8e6499
Compare
Denali uses a 4.8 MHz direct-DMIC rate with the VA path clocked at 19.2 MHz. Validate the sample rate against that clock so the driver selects DIV4, matching the native Windows programming, instead of DIV2. Keep the existing calculation on every other machine. This is based on geoca's Windows-parity analysis in patch 0072. Link: https://github.com/geocausa/SP11X1e-audio/blob/a1d51ecc7416a905acdad50d31600fff7f28ac1c/patches/0072-ASoC-lpass-va-macro-SP11-match-Windows-DMIC-divider.patch Link: 58e36b1 Co-authored-by: geoca <272055834+geocausa@users.noreply.github.com> Signed-off-by: Leon Silcott <leon@boasi.io>
The Surface Pro 11 microphone array feeds the TX macro while the VA macro owns its direct-DMIC pad clocks. Without a cross-macro clock request, the TX capture path cannot reproduce the working firmware sequence. Add an LPASS-internal DMIC clock broker, register the Denali VA macro as its provider, and request DMIC1 then DMIC0 from the TX DEC event group. Validate the exact two-channel Denali route before changing the clocks. Both the provider and consumer paths are gated by the microsoft,denali root compatible. Other machines retain the existing VA and TX behavior; the common broker remains unused on those systems. This implementation follows geoca's Windows-parity work in patch 0078. Link: https://github.com/geocausa/SP11X1e-audio/blob/a1d51ecc7416a905acdad50d31600fff7f28ac1c/patches/0078-ASoC-lpass-SP11-share-VA-DMIC-clock-with-TX-capture.patch Link: 58e36b1 Co-authored-by: geoca <272055834+geocausa@users.noreply.github.com> Signed-off-by: Leon Silcott <leon@boasi.io>
The Surface Pro 11 exposes its microphone array as two 48 kHz PCM channels. The existing VA backend covers the voice path but does not provide the regular TX-macro host capture path. Add a TX macro link through AudioReach TX_CODEC_DMA_TX_3 and route DMIC0 and DMIC1 through the microphone regulator. Keep the existing VA capture link available for low-power use and hardware comparison. Link: ab34e94 Link: 58e36b1 Signed-off-by: Leon Silcott <leon@boasi.io>
f8e6499 to
d03713c
Compare
Summary
Re-lift the Surface Pro 11 TX-macro digital-microphone capture path from upstream-review PR jglathe#88. This fixes the Denali divider, shares physical DMIC clocks with the TX macro, and wires stereo capture in the board device tree.
Containment
microsoft,denaliProvenance
All three focused commits retain Leon Silcott as author and their original author dates. Stable patch IDs match the focused jglathe#88 commits.
Historical pre-sync focused software evidence
At
58fec71de633:git diff --check: passubuntu_x1e_defconfigW=1builds: LPASS macro common, TX macro, VA macroCurrent re-lift verification
The three-commit series was re-lifted unchanged onto current beta bf631f9, producing head d03713c. Ordered stable patch IDs, author identities, and subjects match the pre-sync series, and git range-diff pairs all three commits exactly. GitHub CI and a local detached-head rerun of the exact-current-head integration check pass. A fresh case-sensitive ARM64 W=1 build at exact head d03713c and tree 9f65446bc87f passes the three LPASS codec objects and all three representative DTBs. The X1E OLED, X1P LCD, and Dell hashes are 3f9613c08814, 7afda4b1b8c7, and 7baa7f970464; the non-SP11 Dell DTB is unchanged from beta.
Blocking hardware gates
PR jglathe#79 explicitly recorded TX DMIC capture as unqualified. Both SP11 variants need stereo capture, channel order, playback coexistence, suspend/resume, and VA-path tests; a non-SP11 device must exercise the unchanged capture path.
This PR intentionally remains draft and must not merge on compile evidence alone.