Skip to content

ci: enforce clean per-commit SP11 source deltas - #49

Merged
ooaklee merged 1 commit into
sp11/ubuntu-qcom-x1e-7.2.y-betafrom
sp11/beta-ci-per-commit-checkpatch
Sep 3, 2026
Merged

ci: enforce clean per-commit SP11 source deltas#49
ooaklee merged 1 commit into
sp11/ubuntu-qcom-x1e-7.2.y-betafrom
sp11/beta-ci-per-commit-checkpatch

Conversation

@ooaklee

@ooaklee ooaklee commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Summary

Strengthen the SP11 beta validator without hiding the existing beta-wide checkpatch debt. On pull-request runs, the script derives the current beta tip and real topic head from the checked-out synthetic merge, requires a current linear topic, and runs strict checkpatch on each source-changing commit independently. Any new source ERROR, WARNING, or CHECK fails the job.

Why per commit

The aggregate check remains useful for the complete integration delta, but it collapses intentional commit boundaries. That can create synthetic findings such as a binding-and-driver warning even when those changes are correctly split across patches. Kernel submissions are reviewed as patches, so the new gate evaluates each real topic commit while retaining the aggregate report for historical findings.

Guardrails

  • require the topic head to descend from the current beta tip; stale topics must be re-lifted;
  • reject merge commits in a topic range;
  • run checkpatch.pl --strict on every source-changing commit and reject all three finding severities;
  • retain full-delta artifact, binary, private-content, ancestry, whitespace, and aggregate checkpatch checks; and
  • keep DCO/provenance review separate so contributor trailers are never invented merely to satisfy automation.

Validation

Two independent read-only OpenCode reviews found no gate-bypass defect. The second review specifically approved synthetic-merge parent ordering, Bash behavior, ancestry direction, and linearity enforcement. The workflow already checks out 256 commits, covering every current topic range.

This PR changes CI only and requires no hardware qualification.

Keep the existing beta-wide integration report so historical findings remain visible, but derive the current beta tip and real topic head from the pull-request checkout's synthetic merge. Review each new topic commit independently and reject any new source-level checkpatch error, warning, or check.

Require topic heads to descend from the current beta tip and reject merge commits in the topic range. This makes the reviewed delta exact and forces a relift after beta advances.

Signed-off-by: Leon Silcott <leon@boasi.io>
@ooaklee
ooaklee marked this pull request as ready for review September 3, 2026 12:01
@ooaklee
ooaklee merged commit 91baa27 into sp11/ubuntu-qcom-x1e-7.2.y-beta Sep 3, 2026
1 check passed
@ooaklee
ooaklee deleted the sp11/beta-ci-per-commit-checkpatch branch September 3, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant