Skip to content

feat: bumping eslint to v10 (W-23473845) #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jfeingold35 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: bumping eslint to v10 (W-23473845) #1171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,6 @@ import {fileURLToPath} from 'node:url'

const gitignorePath = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '.gitignore')

export default [includeIgnoreFile(gitignorePath), ...oclif, prettier]
const config = [includeIgnoreFile(gitignorePath), ...oclif, prettier]

export default config
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"@types/node": "^18",
"chai": "^4.5.0",
"commitlint": "^19",
"eslint": "^9.39.5",
"eslint-config-oclif": "^6.0.179",
"eslint": "^10.8.1",
"eslint-config-oclif": "^7.1.4",
"eslint-config-prettier": "^10.1.8",
"husky": "^9.1.7",
"lint-staged": "^15",
Expand Down
2 changes: 2 additions & 0 deletions src/commands/help.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@ export default class HelpCommand extends Command {
static args = {
command: Args.string({description: 'Command to show help for.', required: false}),
}

static description = 'Display help for <%= config.bin %>.'
static flags = {
'nested-commands': Flags.boolean({
char: 'n',
description: 'Include all nested commands in the output.',
}),
}

static strict = false

async run(): Promise<void> {
Expand Down
2 changes: 1 addition & 1 deletion test/commands/help.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {runCommand} from '@oclif/test'
import {expect} from 'chai'
import {readFileSync} from 'node:fs'

const {version: VERSION} = JSON.parse(readFileSync('package.json', 'utf8'))
const {version: VERSION} = JSON.parse(readFileSync('package.json', 'utf8')) as {version: string}
const UA = `@oclif/plugin-help/${VERSION} ${process.platform}-${process.arch} node-${process.version}`

describe('help command', () => {
Expand Down
Loading
Loading