Remove dune-*-experimental - #12765
Merged
Leonidas-from-XIV merged 1 commit intoNov 26, 2025
Merged
Conversation
4 tasks
Alizter
approved these changes
Nov 21, 2025
Leonidas-from-XIV
marked this pull request as ready for review
November 26, 2025 08:38
As we don't want to enable configure flags by default in the nightly anymore, the nightly can just use dune/dune-static going forward. Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
remove-dune-experimental
branch
from
November 26, 2025 08:38
1b180ce to
542379a
Compare
Leonidas-from-XIV
enabled auto-merge (squash)
November 26, 2025 08:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll preface with the fact that I don't know much about Nix or Flakes, so I'm asking reviewers to be extra vigilant when reviewing this:
As we don't want to enable configure flags by default in the nightly anymore, the nightly can just use dune/dune-static going forward. Thus I've removed the
dune-experimentalvariants.Currently a draft, until ocaml-dune/binary-distribution#171 is merged to avoid merging too early, thus breaking the current preview builds.