Skip to content

Replace wording of preview with nightly - #171

Merged
Leonidas-from-XIV merged 1 commit into
ocaml-dune:mainfrom
Leonidas-from-XIV:rebrand-to-nightly
Nov 25, 2025
Merged

Replace wording of preview with nightly#171
Leonidas-from-XIV merged 1 commit into
ocaml-dune:mainfrom
Leonidas-from-XIV:rebrand-to-nightly

Conversation

@Leonidas-from-XIV

@Leonidas-from-XIV Leonidas-from-XIV commented Nov 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

A few things need to be updated:

  • nightly.dune.build needs to be created
  • A 308 redirect from preview.dune.build to nightly.dune.build is required
  • staging-preview.dune.build should be renamed to staging-nightly.dune.build
  • The nightly build should drop the feature flags.

@Leonidas-from-XIV Leonidas-from-XIV mentioned this pull request Nov 14, 2025
Merged
@Leonidas-from-XIV
Leonidas-from-XIV force-pushed the rebrand-to-nightly branch 2 times, most recently from ea82f57 to 6b2b948 Compare November 15, 2025 16:07
Leonidas-from-XIV added a commit to Leonidas-from-XIV/dune-binary-distribution that referenced this pull request Nov 17, 2025
@Leonidas-from-XIV
Fix Shellcheck warning
8251cf2 
Detected in ocaml-dune#171 but can be improved as a separate PR.

Signed-off-by: Marek Kubica <marek@tarides.com>
@Leonidas-from-XIV Leonidas-from-XIV mentioned this pull request Nov 17, 2025
Merged
Leonidas-from-XIV
Leonidas-from-XIV commented Nov 19, 2025
View reviewed changes
Comment thread lib/main.mlx Outdated
@Leonidas-from-XIV

Leonidas-from-XIV commented Nov 19, 2025

Copy link
Copy Markdown
Contributor Author

@mtelvers set up the new names in DNS and I rebased to get the shellcheck improvements in. The only thing missing is thixing the Code block and a review of the copy.

@maiste

maiste commented Nov 19, 2025

Copy link
Copy Markdown
Member

@mtelvers is there a need to update the deployer to point to the new domain's names?

shonfeder
shonfeder reviewed Nov 19, 2025
View reviewed changes

@shonfeder shonfeder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this in place!

I also see one more occurrence of "preview" at https://github.com/ocaml-dune/binary-distribution/pull/171/files (line 181).

What do we need to change to fix this?

Comment thread lib/main.mlx Outdated
Comment thread lib/main.mlx Outdated
Comment thread lib/main.mlx
Comment thread lib/main.mlx Outdated
Comment thread lib/main.mlx Outdated
Comment thread lib/main.mlx Outdated
Comment thread lib/main.mlx
Comment thread lib/main.mlx Outdated
Comment thread lib/main.mlx Outdated
Comment thread lib/main.mlx Outdated
@Leonidas-from-XIV
Leonidas-from-XIV marked this pull request as ready for review November 21, 2025 10:54
@Leonidas-from-XIV Leonidas-from-XIV mentioned this pull request Nov 21, 2025
Merged
@Leonidas-from-XIV

Leonidas-from-XIV commented Nov 21, 2025

Copy link
Copy Markdown
Contributor Author

I've added a commit that switches the targets to be built to the regular ones and opened ocaml/dune#12765 to remove them from the dune flake as they are unused.

shonfeder
shonfeder approved these changes Nov 24, 2025
View reviewed changes

@shonfeder shonfeder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! A few last suggestions on re-review, but they are not necessary or blockers.

Comment thread .github/workflows/binary.yaml
Comment thread README.md
# Dune binaries distribution

This is a webpage for `dune` binaries distribution of `Dune developer Preview`.
This is the web site for for the nightly binary distribution of `dune`.

@shonfeder shonfeder Nov 24, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is the web site for for the nightly binary distribution of `dune`.
This is the website for for the nightly binary distribution of `dune`.

apparently it's one word? https://www.merriam-webster.com/dictionary/website

@Leonidas-from-XIV Leonidas-from-XIV Nov 25, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the link both are fine. Unless you as a native speaker think it is better written together I'm tempted to leave it as-is (I speak concatenative languages, so I might be overcompensating on writing things apart).

Comment thread lib/main.mlx Outdated
shonfeder added a commit to ocaml-dune/setup-dune that referenced this pull request Nov 25, 2025
@shonfeder
Reflect rebrand of "preview" to "nightly"
38877cd 
A correlate of ocaml-dune/binary-distribution#171 

As we prepare to bring milestone https://github.com/ocaml/dune/milestone/62 to a close, we are clarifying the nature of the so called "preview" by rebranding it as merely a nightly binary of dune.
@shonfeder shonfeder mentioned this pull request Nov 25, 2025
Merged
@Leonidas-from-XIV
Replace wording of preview with nightly
53a917a 
Signed-off-by: Marek Kubica <marek@tarides.com>
@Leonidas-from-XIV
Leonidas-from-XIV merged commit 1866e97 into ocaml-dune:main Nov 25, 2025
3 checks passed
@Leonidas-from-XIV
Leonidas-from-XIV deleted the rebrand-to-nightly branch November 25, 2025 08:48
shym pushed a commit to ocaml-dune/setup-dune that referenced this pull request Nov 25, 2025
@shonfeder @shym
Reflect rebrand of "preview" to "nightly"
c51b988 
A correlate of ocaml-dune/binary-distribution#171

As we prepare to bring https://github.com/ocaml/dune/milestone/62 to a
close, we are clarifying the nature of the so called "preview" by
rebranding it as merely a nightly binary of dune.
shonfeder added a commit to shonfeder/vscode-ocaml-platform that referenced this pull request Dec 7, 2025
@shonfeder
Fix version parsing for nightly and dev builds
bb06c92 
In ocaml-dune/binary-distribution#171, the
version printed by the nightly binary build changed its prefix. The
current version parsing logic also doesn't support versions installed
from source using `opam pin dune --dev-repo`. This fixes the version
parsing to handle both cases.
@shonfeder shonfeder mentioned this pull request Dec 7, 2025
Merged
shonfeder added a commit to shonfeder/vscode-ocaml-platform that referenced this pull request Dec 20, 2025
@shonfeder
Fix version parsing for nightly and dev builds
28d32b8 
In ocaml-dune/binary-distribution#171, the
version printed by the nightly binary build changed its prefix. The
current version parsing logic also doesn't support versions installed
from source using `opam pin dune --dev-repo`. This fixes the version
parsing to handle both cases.
smorimoto pushed a commit to shonfeder/vscode-ocaml-platform that referenced this pull request Jan 5, 2026
@shonfeder @smorimoto
Fix version parsing for nightly and dev builds
da78ee1 
In ocaml-dune/binary-distribution#171, the
version printed by the nightly binary build changed its prefix. The
current version parsing logic also doesn't support versions installed
from source using `opam pin dune --dev-repo`. This fixes the version
parsing to handle both cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maiste maiste maiste left review comments
@shonfeder shonfeder shonfeder approved these changes
@Sudha247 Sudha247 Awaiting requested review from Sudha247
@ElectreAAS ElectreAAS Awaiting requested review from ElectreAAS

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Leonidas-from-XIV @maiste @shonfeder