Skip to content

chore(tests): drop unnecessary sleep in count tracker test (PIPE-986) #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dylan-M merged 1 commit into from
Jul 31, 2026
Merged

chore(tests): drop unnecessary sleep in count tracker test (PIPE-986) #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions generator/count/tracker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,9 @@ func TestReset_UnblocksResumeC(t *testing.T) {
default:
}

// Reset in a goroutine
// Reset from a goroutine. The "not closed yet" check above already ran, so there
// is no need to delay before resetting.
go func() {
time.Sleep(10 * time.Millisecond)
tracker.Reset()
}()

Expand Down Expand Up @@ -257,7 +257,9 @@ func TestReset_ConcurrentWithAcquire(t *testing.T) {
}
}()

// Goroutine that resets periodically
// Goroutine that resets periodically. The 1ms spacing is intentional: it spreads
// the resets so they interleave with the concurrent Acquire calls, which is the
// concurrency this test exercises. It is not a wait-for-state sleep.
wg.Add(1)
go func() {
defer wg.Done()
Expand Down
Loading