Skip to content

test(app-shell): the DOM-leak sweep's docblock counts are measured, not remembered #9249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-tesla merged 2 commits into from
Sep 12, 2026
+400 −5
Merged

test(app-shell): the DOM-leak sweep's docblock counts are measured, not remembered #9249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5707dff
test(app-shell): the DOM-leak sweep's docblock counts are measured, n…
os-trump Sep 12, 2026
55b2cce
Merge remote-tracking branch 'origin/main' into claude/issue-8659-ass…
os-trump Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/dom-leak-sweep-docblock-counts-8659.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
---

Test-only change (objectui#8659): the `packages/app-shell` DOM-leak sweep now
asserts the counts its own docblock quotes — re-derived from
`COMPONENTS_PLAIN_TYPES`, `COMPONENTS_SPECIAL_TARGETS` and
`COMPONENTS_LEAK_GROUPS`, and read back out of the file's own prose. Nothing
published moves: the only file touched is `src/__tests__/**`, and
`@object-ui/app-shell` publishes `dist`, `src/styles.css` and the metadata
files, none of which contains it.
Loading
Loading