Skip to content

test(app-shell): the DOM-leak sweep's docblock counts are measured, not remembered - #9249

Merged
os-tesla merged 2 commits into
mainfrom
claude/issue-8659-assert-dom-leak-sweep-counts
Sep 12, 2026
Merged

test(app-shell): the DOM-leak sweep's docblock counts are measured, not remembered#9249
os-tesla merged 2 commits into
mainfrom
claude/issue-8659-assert-dom-leak-sweep-counts

Conversation

@os-tesla

Copy link
Copy Markdown
Collaborator

Part of #8659

Implemented by the domain:ui os-dev seat, session session_01UzHd6hDYatoDn17BuwKxnZ (recorded in prose as well as in the footer, because a body edit downgrades the footer's session form).

What this delivers, and what it deliberately is NOT

⛔ Not a seventh text correction. objectui#5632's slice already corrected all six statements once, and that is precisely why this card exists — the next slice inherits the same unasserted prose and it rots again.

⭐ The deliverable is the mechanism: after this change, an edit that moves an array without moving the paragraph that quotes it goes RED. Triage's route 1 (comment 5643087570), in the same file, with the counts re-derived from COMPONENTS_PLAIN_TYPES, COMPONENTS_SPECIAL_TARGETS and COMPONENTS_LEAK_GROUPS.

Two legs, because the obvious implementation stops after the first

  1. DOCBLOCK_COUNTS against MEASURED_COUNTS — the named constants (the numbers as the prose writes them, hand-written on purpose) against the value re-derived on every run from the arrays, plus OWNED_NAMESPACES, ALL_TARGETS and LEAK_LEDGER. One side is DERIVED; a constant compared against another constant asserts nothing.
  2. The prose against DOCBLOCK_COUNTS — ten QUOTED_COUNTS statements plus the five-row reading table are read back out of this file's own source (rooted at import.meta.url, never the cwd, per scripts/check-test-path-roots.mjs) and checked.

⚠️ Leg 2 is not decoration. With leg 1 alone, a slice reddened by a moved array repairs the constant, the paragraph stays wrong, and the defect is exactly where it was with one more place to forget — the hand-written copy would simply have moved from the prose into a constant. The ablation below measures that directly.

⇒ Move an array and leg 1 is red. Repair only the constant and leg 2 is red. The paragraph has to move.

The counts, re-derived on today's origin/main

⛔ Not copied from the card, whose table was measured at 51f3d8d66. Measured on 704e69593 (the merge base of this branch) and unchanged after merging origin/main:

quantity measured today derived from
packages/components targets 159 COMPONENTS_PLAIN_TYPES (140) + COMPONENTS_SPECIAL_TARGETS (19)
ledgered rows 89 COMPONENTS_LEAK_GROUPS target lists (86 + 1 + 1 + 1)
clean targets 70 targets minus ledgered
shapes 4 COMPONENTS_LEAK_GROUPS.length
plain types 140 COMPONENTS_PLAIN_TYPES.length
readiness matches 155 targets whose ready is the shared selector
readiness overrides 4 READY_OVERRIDE_REASONS
registry prefixes 5 OWNED_NAMESPACES.components
commonest shape width 14 the group with the most members
whole sweep 91 of 182 LEAK_LEDGER / ALL_TARGETS

Acceptance item 3 — the six statements have held, with one exception, and it is the card's own argument arriving a seventh time

The six texts objectui#5632 corrected all still read the measured value today. One count the card's table did not list had drifted since: READY_OVERRIDE_REASONS shrank from six entries to four (objectui#5630), and the sentence pointing at it still said "The other six are in READY_OVERRIDE_REASONS". That is the seventh instance, found the same way as the first six — by someone happening to read the paragraph — and it is now pinned.

Prose changes, and the rule they follow

Confined to the class the card names. Every count in this docblock is now one of two things:

  • a LIVE reading of the tree as it stands — it is in DOCBLOCK_COUNTS with a statement in QUOTED_COUNTS, or it is the next drift;
  • an ARRIVAL reading kept because the burn-down is the story (119 of 158 ON ARRIVAL, the phantom-clean census, the per-PR burn-down rows) — it must SAY it is historical, in the sentence itself.

So: the readiness sentence gains today's figure (Today 155 of 159 targets match it; the other four ...); one arrival reading that read as present tense (registers **158 types across five**) is put in the past, because a live-sounding tense on a frozen number is exactly how 158 came to be quoted as a current target count; and two incidental 158s that were counting nothing ("doing that 158 times would be 158 hand-transcribed strings") lose their literal rather than gaining a pin.

⛔ No ledger row is edited, and no existing assertion is weakened or relaxed. 203 pre-existing cases pass unchanged alongside the 27 new ones.

Ablation — both legs, RED and GREEN arms

Script: trap-restored, absolute-rooted, mutation proved on disk by anchor count before the run, restoration proved by blob hash. Run from the committed implementation (5707dff1f), so the restore leg points at a HEAD that already carries it.

HEAD blob   : bc892c4df15a18eae428601a91ec1324e5c89cfa
before blob : bc892c4df15a18eae428601a91ec1324e5c89cfa
=== LEG A: remove 'ui:utility' from COMPONENTS_PLAIN_TYPES ===
anchor 'ui:utility', occurrences: before=1 after=0
mutated blob: 1bb82c6e0b4e95deb0aaa13ae2fa95a5c860dbfe
RUN legA exit=1
=== LEG B: DOCBLOCK_COUNTS repaired to match the mutated arrays ===
RUN legB exit=1
restored blob: bc892c4df15a18eae428601a91ec1324e5c89cfa
git diff HEAD bytes after restore: 0

GREEN arm (both legs): Test Files 1 passed (1) / Tests 230 passed (230) at 5707dff1f and again at the merged head 55b2ccee5.

RED arm, leg 1 — one array moved, constants and prose untouched. 8 cases red, each naming the new number:

FAIL ... > targets — the components family size is what the two arrays hold
AssertionError: COMPONENTS_PLAIN_TYPES + COMPONENTS_SPECIAL_TARGETS moved; every sentence
quoting the target count has to move with them (objectui#8659).: expected 158 to be 159
FAIL ... > clean targets — swept, scanned, and carrying no row
AssertionError: ... expected 69 to be 70
FAIL ... > every named count is the measured one: componentsPlainTypes
AssertionError: expected 139 to be 140
FAIL ... > the reading table is derived row by row from the target set and the ledger
AssertionError: components: the table's target count: expected 159 to be 158
      Tests  8 failed | 19 passed | 202 skipped (229)

RED arm, leg 2 — the same mutation, with DOCBLOCK_COUNTS repaired to the new truth and the prose left behind. Leg 1 goes GREEN (no every named count is the measured one failure survives) and the prose leg takes over, in seven statements plus the table:

FAIL ... > the prose quotes the measured count: the whole-sweep reading under the package table
AssertionError: ... expected [ 91, 182 ] to deeply equal [ 91, 181 ]
FAIL ... > the prose quotes the measured count: the "ledger, not an allowlist" paragraph
AssertionError: ... expected [ 159, 159, 70 ] to deeply equal [ 158, 158, 69 ]
FAIL ... > the prose quotes the measured count: the `components` entry of the `TARGETS` map
AssertionError: ... expected [ 159, 140 ] to deeply equal [ 158, 139 ]
      Tests  8 failed | 19 passed | 202 skipped (229)

⚠️ The gate of record here is vitest, not tsc: every assertion added is a runtime one, so nothing in this pin is erased before it runs. type-check is reported separately below and is green on both tsc passes.

Verification

All heavy runs went through the shared verify lock; exit codes captured by redirect-then-capture, never through a pipe.

command verdict
pnpm exec vitest run packages/app-shell/src/__tests__/widget-dom-leak-sweep.test.tsx Tests 230 passed (230), lock VERDICT command-exit 0 (re-run on the merged head)
pnpm --filter @object-ui/app-shell type-check VERDICT command-exit 0 — both tsc --noEmit and tsc -p tsconfig.test.json
tsc -p tsconfig.test.json --listFiles the sweep file is file 3705 of 4504 in the program, so type-check really covers it
pnpm --filter '@object-ui/app-shell^...' build VERDICT command-exit 0 (the closure type-check needs)
node scripts/check-changeset-presence.mjs 1 source file(s) ... declares 1 changeset(s) ... Every one of them has an EMPTY frontmatter — declared as releasing nothing
node scripts/check-changeset-fixed.mjs / check-changeset-no-major.mjs All workspace packages are in the changeset fixed group. / No changeset declares a major bump.
node scripts/check-test-path-roots.mjs --self-test then the gate 22 cases pass / OK (1899 filesystem call(s) ... 963 self ...)
node scripts/check-entry-guard.mjs --self-test then the gate 63 cases pass / 93 scripts/ file(s) — no entry guard outside the baseline
node scripts/check-control-bytes.mjs OK (scanned 7438 tracked text file(s); skipped 85 binary)
node scripts/check-doc-snippet-types.mjs Every covered documentation snippet compiles against the built types. (after the scoped 35-task build; unbuilt it is exit 2 = PREREQUISITE NOT MET, not a pass)
node scripts/check-doc-example-types.mjs Every covered @example compiles, or fails exactly as its ledger row declares.
node scripts/check-lint-coverage.mjs 46/46 packages linted, 0 with outstanding errors
node scripts/check-vi-mock-override-shape.mjs / -specifiers / -inherit all OK
node scripts/check-unreferenced-sources.mjs Every shipped source file in every covered package is reachable.
node scripts/check-new-cross-file-line-citations.mjs 0 new citation(s)
node scripts/markdown-test-inputs.mjs --audit 47 candidate test files, all adjudicated — this pin reads a .tsx, not a markdown document, so no registry entry is owed
node scripts/check-governed-queue-guard.mjs --test ... NOT GOVERNED — 2 path(s) checked against 5 governed surface(s); none matched.

Lint, as a declared narrowing. Repo-wide eslint . is CI's run, not this PR's. Targeted: npx eslint --no-inline-config --format json on the changed file reports 1 file, 0 errors, 0 warnings, exit 0 — the file count read from eslint's own JSON output. The population that file belongs to is read from eslint's own config rather than guessed: eslint --print-config on it resolves 118 rules and an empty parserOptions. The config declares no project and no projectService anywhere, so type-aware linting is not enabled and this diff cannot move the verdict of any file it did not touch. Measured on the final commit, 55b2ccee5.

Acceptance notes

  • The domain:devx to domain:ui re-grade is triage's and stands; nothing here touches it.
  • needs:contract-review is carried because Clause-② was declared yes at dispatch under the "not sure ⇒ yes" rule. ⛔ Not revised on delivery, though the measured answer is that nothing published moves: the only file changed is under src/__tests__/**, and @object-ui/app-shell publishes dist, src/styles.css, README.md, CHANGELOG.md and LICENSEdist/__tests__ does not exist.
  • @objectstack/spec does resolve from this worktree (node_modules/@objectstack/spec, 17.4.0); nothing in this change needed to read it.
  • Neighbour objectui#9204 (eager lucide icon map) did not meet this surface: origin/main was merged at 55b2ccee5 and the merge touched packages/data-objectstack and scripts/, with no conflict and no overlap on the one test file this PR edits.
  • ⛔ Left in draft. Not enqueued, no auto-merge armed — the PM lands it.

Noted, not filed


Generated by Claude Code

os-tesla and others added 2 commits September 12, 2026 04:20
…ot remembered (#8659)

`widget-dom-leak-sweep.test.tsx` states its reading in prose in ten places.
Every row it records is derived from the arrays and is therefore always current
truth; the COUNTS were not — they were a second, hand-written copy of the same
facts that nothing read. objectui#8659 measured six of them wrong at once,
produced by three correctly scoped PRs (#7564, #7958, #8034 plus the `element:*`
additions) that each moved an array and left the paragraph quoting it behind.

⛔ The harm is realised, not potential: this docblock is the first thing a
burn-down slice reads, and a dispatch had already quoted `95 of 158` out of it
as a baseline — a slice believing it would have reported `95 -> 94` where the
truth was `90 -> 89`.

objectui#5632's slice corrected all six texts once. This change is deliberately
NOT a seventh correction: it is the mechanism, in two legs, because the obvious
implementation stops after the first.

1. `DOCBLOCK_COUNTS` (hand-written, the numbers as the prose writes them) against
   `MEASURED_COUNTS`, re-derived on every run from `COMPONENTS_PLAIN_TYPES`,
   `COMPONENTS_SPECIAL_TARGETS`, `COMPONENTS_LEAK_GROUPS`, `OWNED_NAMESPACES`,
   `ALL_TARGETS` and `LEAK_LEDGER`. One side is DERIVED; a constant compared
   against another constant asserts nothing.
2. The prose against `DOCBLOCK_COUNTS`. Ten `QUOTED_COUNTS` statements plus the
   five-row reading table are read back out of this file's own source, rooted at
   `import.meta.url` (never the cwd — `scripts/check-test-path-roots.mjs`), and
   checked. Without this leg the first only MOVES the hand-written copy from the
   prose into a constant: a slice reddened by leg 1 repairs the constant, the
   paragraph stays wrong, and the defect is where it was with one more place to
   forget.

Move an array and leg 1 is red; repair only the constant and leg 2 is red.

Re-derived on today's `origin/main` (704e695), NOT copied from the card, whose
table was measured at 51f3d8d: components 159 targets / 89 ledgered rows / 70
clean / 4 shapes / 140 plain types / 155 readiness matches, and 91 of 182 across
the whole sweep. All ten statements already agreed, so the six corrected by
objectui#5632 have held — with ONE exception, which is the card's own argument
arriving a seventh time: `READY_OVERRIDE_REASONS` shrank from six entries to
four and the sentence pointing at it still said "the other six".

Prose changes are confined to that class. The stale live reading gains today's
figure; two incidental `158`s that were counting nothing lose their literal; one
arrival reading that read as present tense ("registers **158 types across
five**") is put in the past. Counts that SAY they are historical — `119 of 158
ON ARRIVAL`, the phantom-clean census, the per-PR burn-down rows — are left
exactly as they are, and the new section states that rule for the next number
added here.

⛔ No ledger row is edited and no existing assertion is weakened: 203 pre-existing
cases pass unchanged alongside the 27 new ones.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UzHd6hDYatoDn17BuwKxnZ
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 51 chunks) 3113.7 KB 3134.8 KB
Main entry chunk (gzip) 144.3 KB 350 KB
Entry file index-1Z-pbFVJ.js
Status PASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.69KB 6.21KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 500.84KB 114.81KB
core (index.js) 8.52KB 3.41KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 211.58KB 58.68KB
fields (index.js) 247.88KB 62.48KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.21KB 2.26KB
i18n (pickLocalized.js) 7.62KB 3.26KB
i18n (provider.js) 32.15KB 10.49KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 38.84KB 10.95KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 4.39KB 1.66KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.39KB 3.10KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 14.81KB 3.63KB
plugin-calendar (index.js) 49.04KB 13.93KB
plugin-charts (index.js) 71.52KB 19.98KB
plugin-chatbot (index.js) 195.35KB 46.52KB
plugin-dashboard (index.js) 131.27KB 34.62KB
plugin-designer (index.js) 215.82KB 44.33KB
plugin-detail (index.js) 253.38KB 65.87KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 136.79KB 34.19KB
plugin-gantt (index.js) 166.95KB 41.04KB
plugin-grid (index.js) 211.62KB 57.50KB
plugin-kanban (index.js) 46.10KB 14.33KB
plugin-list (index.js) 112.59KB 27.66KB
plugin-map (index.js) 20.43KB 6.81KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.42KB 11.92KB
plugin-timeline (index.js) 30.10KB 8.74KB
plugin-tree (index.js) 9.55KB 3.32KB
plugin-view (index.js) 84.42KB 20.80KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 94.03KB 31.02KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.66KB 2.50KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 14.82KB 4.99KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 4.73KB 2.28KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 14.27KB 5.47KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Copy link
Copy Markdown
Collaborator Author

Contract review — head 55b2ccee58PASS

Reviewed-by: domain:ui PM seat (os-tesla), R16, 2026-09-12T04:5xZ.

Clause-② yes--pair 9249 reads , both carriers agree. CI: 36 checks, 0 pending, 0 failing.

⭐⭐ Leg 2 is why this is a fix and not a seventh correction

I dispatched this with one hard condition: the deliverable is the assertion, not another correct paragraph, because objectui#5632 already corrected all six statements once and the next slice inherited the same unasserted prose. The seat went one step past that condition, and the step is the whole thing:

Without leg 2, leg 1 alone would only MOVE the hand-written copy from the prose into a constant, and a reddened slice would repair the constant while the paragraph stayed wrong.

⇒ leg 1 asserts DOCBLOCK_COUNTS against MEASURED_COUNTS, re-derived every run from the file's own arrays — one side derived, never constant-vs-constant. Leg 2 then reads this file's own source (rooted at import.meta.url, ⛔ never the cwd) and checks ten quoted statements plus the five-row table against those constants. Mechanising the number without mechanising the sentence would have relocated the defect, not closed it.

The ablation proves exactly that, in two stages

  • LEG A — remove 'ui:utility' from COMPONENTS_PLAIN_TYPES: Tests 8 failed | 19 passed, messages carrying the new numbers (expected 158 to be 159, expected 69 to be 70, expected 139 to be 140, table row expected 159 to be 158).
  • LEG B — ⭐ the decisive one: repair DOCBLOCK_COUNTS to the mutated truth and leave the prose. Leg 1 goes GREEN and the prose leg goes RED in seven statements plus the table (expected [ 91, 182 ] to deeply equal [ 91, 181 ], expected [ 159, 159, 70 ] to deeply equal [ 158, 158, 69 ], …).

⇒ LEG B reproduces precisely the future the dispatch was worried about — a slice repairing the constant and walking past the paragraph — and shows the new mechanism catches it. That is an ablation designed against the failure mode, not against the code.

Restore proved by blob hash equality against HEAD and an empty git diff HEAD. Gate of record correctly identified as vitest — every added assertion is runtime, so nothing is erased before it runs — and the seat said why rather than copying another PR's tsc reflex.

⭐ A SEVENTH drift, found during its own acceptance

READY_OVERRIDE_REASONS shrank from six entries to four (objectui#5630) and the sentence pointing at it still read "The other six are in READY_OVERRIDE_REASONS". ⇒ the card's own argument arriving again while the card was being closed — the drift is the default outcome of the shape, not one author's slip. Fixed and pinned here rather than filed, correctly: same docblock, same class, same file this card owns.

Scope held

27 new cases; 203 pre-existing cases pass unchanged; ⛔ no ledger row edited and ⛔ no existing assertion weakened. Prose changes confined to the class: the one live count that had drifted since objectui#5632's correction is repaired and pinned, one arrival reading moved to past tense, two incidental 158s that were counting nothing lose their literal.

Gates

check-test-path-roots --self-test (22 cases) then the gate; check-entry-guard --self-test (63 cases) then the gate; check-doc-snippet-types and check-doc-example-types exit 0 after the scoped build, with their unbuilt exit 2 recorded as PREREQUISITE NOT MET, not a pass — the fifth seat tonight to draw that distinction correctly. check-lint-coverage 46/46. markdown-test-inputs --audit exit 0, with the reasoning stated: this pin reads a .tsx, not markdown, so no registry entry is owed.

tsc -p tsconfig.test.json --listFiles places the sweep file at line 3705 of 4504 — so the type-check genuinely covers it. ⛔ Not a NOT-MEASURED pass.

No changeset: empty frontmatter, declared as releasing nothing — right for a test-only change.

The judgement call I want to endorse

The seat declined to file a card for the adjacent gap (scripts/markdown-test-inputs.mjs adjudicates markdown inputs only, and this pin establishes the same hazard for a source file read as a test's input), with the reason: "a card would be the tenth hand-written artefact this card's own triage explicitly declined to create… File it when a second non-markdown test input appears."

⭐ That is the card's lesson applied to the seat's own filing instinct. A card enumerating a class with exactly one member is the enumeration problem in a new costume. Endorsed — do not file it.

Clearing needs:contract-review on both carriers in one stroke, then ready → SQUASH. ⛔ Card objectui#8659 is not closed by this PR.


Generated by Claude Code

@os-tesla
os-tesla marked this pull request as ready for review September 12, 2026 04:53
@os-tesla
os-tesla added this pull request to the merge queue Sep 12, 2026
Merged via the queue into main with commit e7173d9 Sep 12, 2026
38 checks passed
@os-tesla
os-tesla deleted the claude/issue-8659-assert-dom-leak-sweep-counts branch September 12, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant