Repository navigation
feat(web): one filter menu for multi-select inboxes and environments - #79
Conversation
The sidebar's single-choice "Inbox" dropdown forced "All threads" to see a founder's threads and agent threads together, and two rows of selects sat between search and the list. The sliders button next to Search now opens one menu with multi-select Inbox (Kameron, Agents, Jeff, Shared) and Environments sections, live counts, a connection dot, and "Reset to default". The default is the chosen founder plus Agents. A dot on the button marks a non-default view. Search still looks across every thread. The owner for new threads moves to Settings > Threads > Inbox. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lls in Jeff's and Shared threads Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Independent bot review (Claude Sonnet 5.5 via T3 delegation), head 74dd322 No blocking findings. Static review plus What I checked and found correct:
should-fix
nit
Anti-overengineering: CI guard ( |
- An empty saved inbox choice falls back to the default instead of blanking the list. - Toggling an environment keeps hidden ids of machines this client has not loaded yet, so an offline machine stays hidden. - The last checked option says why it can't be unchecked. - inboxMenuOrder uses Founder.literals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…box-lanes Conflict was only the threadInbox.test.ts import list. The sidebar's filter test now files its agent threads to a founder with a reason, since under this PR an agent's unreasoned filing stays in Agents; an assertion pins that. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Kameron couldn't see just his own threads and agent threads together. The sidebar's single-choice "Inbox" dropdown forced "All threads", which shows 200+ threads. Two rows of selects ("Inbox" and "New threads") also sat between the search bar and the list.
What changed
matchesInboxViewitself is unchanged.founderInboxFilterreplacesfounderInboxView, plussidebarHiddenEnvironmentIds. Old saved settings still decode, and the old single choice isn't carried over. Environments are stored as hidden IDs, so a newly linked machine shows up by default.SidebarInboxBar.tsx, and the new logic test runs in CI.Differences from the proposed design
Review round
One independent bot review (Claude Sonnet 5.5 via T3 delegation) at `74dd322422`: no blocking findings. A Codex attempt before it hit a rate limit and reviewed nothing. Fixed in `01d578e1ac`: an empty saved inbox choice no longer blanks the list (5); hidden machines that haven't loaded yet stay hidden (6); the last checked option says why it stays checked (8); `Founder.literals` (9).
Kept as designed:
Noted, not changed:
Screenshots (dev server with demo data)
Default for Kameron: Kameron + Agents, with Jeff's and Shared threads hidden:
Jeff checked from the keyboard: Jeff's threads appear, the button gets a dot, and Reset to default shows:
Settings → Threads → Inbox:
The demo server has only one environment, so these captures don't show the Environments section. Its filtering, counts and default rules are covered in
threadListFilter.logic.test.ts.Verification
vp test runonthreadInbox.test.ts,threadListFilter.logic.test.ts,settingsSearch.test.ts,SettingsPanels.logic.test.ts,ThreadNotificationCoordinator.logic.test.ts,ThreadNotificationCoordinator.badge.browser.test.ts,Sidebar.logic.test.tsandSidebar.browser.test.tsx: 8 files, 179 tests passed before the single-inbox fix. The two directly affected files were rerun after it and pass (17 tests).@t3tools/contractsand@t3tools/webis clean, and format and lint pass on the changed files.check:changed's knip step flags only the 4 upstream scripts that were already unused on this base, plusINBOX_CAPABILITY, which was already exported and unused.menuitemcheckboxitems with names like "Kameron, 1 active" andaria-checked. Arrow keys and Enter toggle an item, and the menu stays open.Coordinated with: Thread hygiene across the fleet (server-side stale-run reconcile and environment visibility), and the founder-inbox lane-semantics task, which edits
founderInboxLanein the same file.Opus 5.5 via Claude Code in T3 Code.
🤖 Generated with Claude Code