Skip to content

fix(web): don't attribute new threads to Kameron before an owner is chosen - #65

Merged
nullStack65 merged 1 commit into
release/native-0.1.10from
fix/native-0.1.10-unset-owner-origin
Nov 18, 2026
Merged

nullStack65 merged 1 commit into
release/native-0.1.10from
fix/native-0.1.10-unset-owner-origin

Conversation

@nullStack65

Copy link
Copy Markdown
Owner

Why

After PR #64, a client with no chosen owner shows All, which is correct. It still attributed every new thread to Kameron (founderInboxOwner ?? "kameron" in apps/web/src/state/threads.ts). So on a fresh or upgraded Jeff client, his new routine work filled Kameron's inbox and was missing from Jeff's own view. That violates "founder defaults hide the other founder's routine work".

Is a first-run prompt required?

No. Nothing in the client or environment knows which founder is using it; PR #59 added only a threadInbox capability flag. Correct behaviour therefore needs either a user choice or no attribution, and the server already supports the second. With no inboxOrigin, a human-created thread gets no inbox record (Orchestrator.ts, thread.create), so it's unclassified and visible in All, like legacy history. The owner is chosen with the existing pickers; PR #64's New threads picker shows Not set until then. A first-run prompt would only help people find that choice. It isn't needed to stop misattribution, so it's left out.

Change

  • Contracts: inboxOriginFor(settings) returns the chosen founder as a human origin, otherwise undefined.
  • The web thread commands use it, replacing the Kameron fallback. Mobile already sends no origin.

Verification (local ASUS, no paid calls)

  • New acceptance case:
    • no owner → no origin, so the thread is hidden from Kameron/Jeff/Agents/Shared and visible in the resolved All view
    • owner Jeff → a Jeff origin, so it shows in Jeff's view and not Kameron's
  • Typecheck: contracts, web, client-runtime and server, 0 errors.
  • Workflow tests: 6 files, 104 passed.
  • Adjacent tests: threads, threadCommands, settings, 3 files, 62 passed.
  • Format/lint: changed files pass.
  • Pre-commit hook skipped: the same knip findings exist on the base.

The qualified AppImage from 0c98c477 (4ad5a550…) is not affected by this PR.

Task: CLO-866

🤖 Generated with Claude Code

…hosen

With no owner chosen (any upgraded or fresh client), new threads were sent
with a Kameron origin, so a Jeff client filled Kameron's inbox and its own
work was missing from Jeff's view. Send no origin until an owner is
chosen: the server then creates no inbox record, so the thread is
unclassified and visible in All, which is the view an unchosen client
resolves to, exactly like legacy history. Once an owner is picked in the
Inbox or New threads picker, new work is attributed to that founder.

Task: CLO-866
Model: claude-opus-5-5

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nullStack65

Copy link
Copy Markdown
Owner Author

RESULT

RESULT (CLO-866): head c7056fbbdbbdf9c5107320c11c168d30ce5d303a (parent 0c98c477). ARC run 44227524281, job 134544240115 on t3code-ci-arc-s5fvz-runner-dqq5d: success, 15/15 steps, 104 tests. Merge source 7d011774aee5af8ea771e359ef96fcb150847104.

Unchosen clients now send no origin, so new threads are unclassified and visible in All, instead of being attributed to Kameron. A first-run prompt isn't needed for correctness.

Local checks: typecheck 0 errors; adjacent tests 62/62.

Merge path: SHA-guarded squash of c7056fbb into release/native-0.1.10. The 0c98c477 AppImage (4ad5a550…) predates this and still attributes unchosen-owner threads to Kameron until Jeff picks his view once.

@nullStack65
nullStack65 merged commit 09531d1 into release/native-0.1.10 Nov 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant