Repository navigation
fix(web): don't attribute new threads to Kameron before an owner is chosen - #65
Merged
nullStack65 merged 1 commit intoNov 18, 2026
Conversation
…hosen With no owner chosen (any upgraded or fresh client), new threads were sent with a Kameron origin, so a Jeff client filled Kameron's inbox and its own work was missing from Jeff's view. Send no origin until an owner is chosen: the server then creates no inbox record, so the thread is unclassified and visible in All, which is the view an unchosen client resolves to, exactly like legacy history. Once an owner is picked in the Inbox or New threads picker, new work is attributed to that founder. Task: CLO-866 Model: claude-opus-5-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
RESULTRESULT (CLO-866): head Unchosen clients now send no origin, so new threads are unclassified and visible in All, instead of being attributed to Kameron. A first-run prompt isn't needed for correctness. Local checks: typecheck 0 errors; adjacent tests 62/62. Merge path: SHA-guarded squash of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After PR #64, a client with no chosen owner shows All, which is correct. It still attributed every new thread to Kameron (
founderInboxOwner ?? "kameron"inapps/web/src/state/threads.ts). So on a fresh or upgraded Jeff client, his new routine work filled Kameron's inbox and was missing from Jeff's own view. That violates "founder defaults hide the other founder's routine work".Is a first-run prompt required?
No. Nothing in the client or environment knows which founder is using it; PR #59 added only a
threadInboxcapability flag. Correct behaviour therefore needs either a user choice or no attribution, and the server already supports the second. With noinboxOrigin, a human-created thread gets no inbox record (Orchestrator.ts,thread.create), so it's unclassified and visible in All, like legacy history. The owner is chosen with the existing pickers; PR #64's New threads picker shows Not set until then. A first-run prompt would only help people find that choice. It isn't needed to stop misattribution, so it's left out.Change
inboxOriginFor(settings)returns the chosen founder as a human origin, otherwiseundefined.Verification (local ASUS, no paid calls)
threads,threadCommands,settings, 3 files, 62 passed.The qualified AppImage from
0c98c477(4ad5a550…) is not affected by this PR.Task: CLO-866
🤖 Generated with Claude Code