Skip to content

fix(web): default to the chosen founder's inbox, All until one is chosen - #64

Merged
nullStack65 merged 1 commit into
release/native-0.1.10from
fix/native-0.1.10-founder-default
Nov 18, 2026
Merged

nullStack65 merged 1 commit into
release/native-0.1.10from
fix/native-0.1.10-founder-default

Conversation

@nullStack65

Copy link
Copy Markdown
Owner

Why

The product requirement is that a founder's default inbox hides the other founder's routine work and agent-only threads, while All and Agents stay reachable. PR #63 defaulted the view to All so upgraded devices keep untagged history visible. That part is right, but it left an acceptance gap for new founder clients:

  • Both founder keys were decoding defaults (all / kameron), and client settings are saved as a whole snapshot (persistClientSettingsPatch → setClientSettings). The first unrelated settings write therefore stored them as if chosen, so the client could never tell "not chosen yet" from "chose All".
  • There is no first-run founder prompt, and no environment-level founder identity: PR feat(threads): organize the shared fleet into founder inboxes #59 only added a threadInbox capability flag. Choosing an owner under New threads never moved the view.
  • The result: a new founder client stays on All indefinitely, showing the other founder's routine work and all agent-only threads.

Change

  • ClientSettingsSchema: founderInboxOwner and founderInboxView become optional keys, so absent means not chosen. ClientSettingsPatch is unchanged.
  • effectiveInboxView(settings) in contracts = saved view, else the chosen founder's view, else All. The sidebar, both notification filters and the picker use it.
  • Upgraded devices and clients with no founder chosen stay on All, so legacy history is not hidden.
  • Once a founder is chosen (Inbox picker or New threads picker), the default is that founder's view. All and Agents stay one pick away, and an explicit pick, All included, is saved and wins.
  • The New threads picker shows Not set until an owner is chosen. New threads from such a client keep today's Kameron attribution.
  • Devices that already saved values (any earlier inbox build) keep exactly what they saved. No migration and no data rewrite. No new access control.

Verification (ASUS, local, no paid calls)

  • New assertion on unchanged 3b37bf8a: fails. The resaved snapshot of a device that never chose contains founderInboxView and founderInboxOwner.
  • With the fix: the acceptance case passes:
    • an upgraded device resolves to All and legacy is visible
    • choosing Jeff as owner resolves to Jeff, hiding Kameron's routine and agent-only threads, with Agents and All still matching
    • every explicit view round-trips
  • Typecheck: contracts, web, client-runtime and server, 0 errors.
  • Workflow tests: 6 files, 103 passed.
  • Adjacent tests: 8 files, 192 passed (settings, useSettings, clientPersistenceStorage, scopedSettings, desktop client settings, sidebar and notification logic, threads).
  • Format/lint: changed files pass.
  • Pre-commit hook skipped: it fails on knip findings that are identical on 3b37bf8a (4 upstream unused files and INBOX_CAPABILITY).
  • No before/after captures: this host has no display. The only visible change is the "Not set" option in the New threads select.

Not changed

  • The qualified 3b37bf8a AppImage (a7563bd6…) staged for Omarchy. If it's installed before this lands and any setting is saved, that device stores All and stays there until Jeff picks his view.
  • Remaining gap, not addressed: a client that never chooses an owner attributes new threads to Kameron. A first-run owner prompt would close it.

Task: CLO-866

🤖 Generated with Claude Code

PR63 made the inbox view default to All so upgraded devices keep their
untagged history visible. Both founder keys were still decoding defaults,
and client settings are saved as a whole snapshot, so the first unrelated
settings write stored founderInboxView "all" and founderInboxOwner
"kameron" as if chosen. A new founder client then stayed on All, showing
the other founder's routine work and agent-only threads, and choosing an
owner under New threads never moved the view.

Make both keys optional, so absent means not chosen, and resolve the view
in one place: the saved view, else the chosen founder's view, else All.
Upgraded devices and fresh clients without a founder stay on All; once a
founder is chosen, the default hides the other founder's routine work and
agent-only threads, while All and Agents stay one pick away. The owner
picker shows "Not set" until chosen. New threads from a client with no
chosen owner keep today's Kameron attribution.

Task: CLO-866
Model: claude-opus-5-5

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nullStack65

Copy link
Copy Markdown
Owner Author

RESULT

RESULT (CLO-866, founder-inbox acceptance gap): fixed on this PR and CI green. Not merged.

  • Head: 1ec175272bdedda60a2ad6dbfcf285d962e5f942, parent release/native-0.1.10 3b37bf8a7ab54fe275275f729494bb38d3a3b4df.
  • CI: ARC run 44220118694, job 134519586745 on t3code-ci-arc-s5fvz-runner-z5qrl, merge source 1e401b587c8a930840b897d4e85e252c32aacb72: success. Every step passed: source guard, typechecks, 6 files / 103 tests, server and web builds, output check.
  • Gap: both founder keys were decoding defaults, and client settings are saved as a whole snapshot, so a new founder client recorded All and Kameron as if chosen and stayed on All. There is no first-run prompt and no environment founder identity to fall back on.
  • Fix: both keys are optional. The view is the saved view, else the chosen founder's view, else All:
    • upgraded and unchosen clients keep legacy history visible
    • a chosen founder defaults to their own view, which hides the other founder's routine work and agent-only threads; All and Agents stay reachable
  • Local checks: the new assertion fails on 3b37bf8a and passes with the fix. Adjacent tests pass (8 files, 192 tests), and typecheck is clean for contracts, web, client-runtime and server.
  • Unchanged: the 3b37bf8a AppImage (a7563bd6…). Remaining gap: unchosen owners still attribute new threads to Kameron; a first-run owner prompt would close it.
  • Merge path: SHA-guarded squash of 1ec175272bdedda60a2ad6dbfcf285d962e5f942 into release/native-0.1.10.

@nullStack65
nullStack65 merged commit 0c98c47 into release/native-0.1.10 Nov 18, 2026
2 checks passed
@nullStack65

Copy link
Copy Markdown
Owner Author

RESULT

RESULT (CLO-866): Linux x64 desktop AppImage built from merged release/native-0.1.10 0c98c4772938d4f7b59539e01c2f3dab8749a32e (this PR) and qualified. Not installed.

  • Artifact: T3-Code-0.1.10-x86_64.AppImage, 0.1.10, 250,655,931 bytes, sha256 4ad5a5508a0846603881b852439c04cb619eab8decd624f1bf7ecb23a498d37b. Manifest sha256 cae0d961cff43f9b42703d6c2841a81ad88237e9a27dd779e78a8799aa05b3de.
  • Where:
    • ASUS read-only copy: ~/.local/share/closura/t3-release-staging/clo866-desktop-0.1.10-0c98c477/
    • private standalone draft prerelease 449467681, assets 761632881 (AppImage) and 761632880 (manifest). Digests match, no tag, no runs.
    • No download links were created. The prior 3b37bf8a copy (draft 449424466, staging directory) is untouched for rollback.
  • Source: tree e1b78ad77c9fe775af9a7ad551176be308d3847f, equal to the CI-green PR head (ARC run 44220118694). The bundle embeds 0c98c4772938. Built in a clean worktree with scripts/closura/build-linux-desktop-noble.sh; 0 tracked changes afterwards.
  • Checks:
    • glibc: 50 ELF files, max GLIBC 2.39 / GLIBCXX 3.4.22.
    • Native PTY: node-pty built by noble gcc 13.3.0; a real spawn returned pty-ok, exit 0.
    • Electron: identical to official v0.1.10.
    • Package contents: no escaping or absolute symlinks, no setuid, no update feed.
    • Qualifier: 11/11 gates pass (AssemblyAI endpoint, header, word_boost and settings; founder inbox; All view; public relay config; no credentials; version).
    • Inbox default: the shipped rule is founderInboxView ?? founderInboxOwner ?? "all", with no persisted founder default.
    • Smoke test: t3 v0.1.10, HTTP 200, isolated.
    • Mocked voice and inbox tests: 16/16, no network.
  • Note: the Air recipe's pinned server/web reference is still the 26e726e2 build, so on this source it skips that cross-check with a warning. Refresh it once the attribution fix (fix(web): don't attribute new threads to Kameron before an owner is chosen #65) settles.

@nullStack65

Copy link
Copy Markdown
Owner Author

CHECKPOINT

HANDOFF (CLO-866): preferred Omarchy cutover candidate, for the approved private transfer. Non-secret; no links.

  • Preferred: T3-Code-0.1.10-x86_64.AppImage from nullStack65/t3code release/native-0.1.10 0c98c4772938d4f7b59539e01c2f3dab8749a32e (tree e1b78ad7…, embedded 0c98c4772938).
    • 250,655,931 bytes, sha256 4ad5a5508a0846603881b852439c04cb619eab8decd624f1bf7ecb23a498d37b
    • manifest.json: 3,598 bytes, sha256 cae0d961cff43f9b42703d6c2841a81ad88237e9a27dd779e78a8799aa05b3de
  • Private locations:
    • ASUS ~/.local/share/closura/t3-release-staging/clo866-desktop-0.1.10-0c98c477/ (mode 444). It holds the AppImage, manifest.json and a machine-readable HANDOFF.json (sha256 45777192722e1a667285c25cd128957bfc6970d90fd301b6e4f0e0fd002df31d).
    • Private standalone draft 449467681, assets 761632881 and 761632880.
  • Transfer: copy over the approved private SSH route from the ASUS directory, then verify the sha256 on arrival. No signed URLs in any message.
  • Qualified: 11/11 package gates, glibc ≤ 2.39, real PTY, Electron identical to official, no update feed, no credentials, bundled server HTTP 200, mocked voice and inbox 16/16.
  • Do not select (rollback only): 3b37bf8a a7563bd6… and 6ebd01cb a0394245….
  • Cutover note: pick Jeff once in the Inbox or New threads picker after first launch. That sets his default view and attributes his new threads to him, so PR fix(web): don't attribute new threads to Kameron before an owner is chosen #65 (open, ARC green) needs no rebuild for this host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant