Repository navigation
Card Builder controls for the groups of buttons - #353
Merged
Merged
Conversation
A button is sent to another group from its menu (the first group's order line, or a group's own line under Groups) or dragged in the preview: along its group, onto a button of another group to join it there, or onto an area (left, center, right, bottom, a strip at the top) to make a group there or join the one that is. A group has its own area, up and down, across and rows; a group left with no button is gone. The first group alone keeps the paper button and the parts among the buttons. regroup, claimed and friends in model.js are pure and tested. The recording of Chrome's layout is stamped again (Card.astro has a data-g). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
nstarman
added a commit
that referenced
this pull request
Oct 6, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Preview: https://044b35a0.nstarkman-space.pages.dev Built from |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing code or schema
What and why: the buttons became groups in #346 (
buttons:code,docs:left-buttons:stars:right); the Card Builder carried them through but had no way to edit them. It does now, with menus and by dragging.allin the first group is all but what other groups have.regroup,claimed,mainLinks,newGroupinmodel.jsare pure and tested (27 new tests: moves along, out, in, new group, the paper button staying, nothing mutated, controls reading a name back,allin another group). The DOM side was checked in a browser by driving it: menu → new group, area/up and down/rows, back; and dragging docs onto stars, stars onto docs, docs back onto code, code to the bottom edge, each giving the expected name.data-gon each list so the preview knows its group;cardFace's groups carry their number.Screenshots
unxt. Sending stars to a new group from its → menu; the Groups row appears, the preview shows the group:
Its area set to the left and its up and down to the bottom — the stars at the foot of the left side, the other buttons on the right:
After dragging in the preview (docs onto stars, stars onto docs, docs back onto code, code to the bottom edge) —
buttons:paper,docs:right-buttons:stars:left-buttons:code:bottom:npm run test:schemapasses; 701 unit tests and the build pass🤖 Generated with Claude Code