Repository navigation
Keep a button's label out of the card text in the word-keeping property test - #355
Merged
Merged
Conversation
Contributor
|
Preview: https://4fb1bce4.nstarkman-space.pages.dev Built from |
…rty test At some widths a button's year label is the same size as the body text, so the test counted "0000" as body text and failed at random. A link is not body text. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
nstarman
force-pushed
the
fix-wrap-join-test
branch
from
October 6, 2026 22:02
ed922a0 to
48faff2
Compare
nstarman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing code or schema
What and why:
tests/cardlayout.property.test.js› keeps every word of the text and of the role still fails at random onmain, now by a different input than the one #354 fixed: at some widths a button's year label (e.g.0000) is the same size as the body text, so the test counts it as body text (… 0000). The body filter now skips links.Found by running the property at
FC_RUNS=3000; with this change it passes atFC_RUNS=5000, andnpm testis 717 passed.(This PR first also fixed the space after
–/?breaks; #354 landed that fix meanwhile, so the branch was rebased onto it and only this part remains.)npm run test:schemapasseslink.relvalue or atypewas added, every renderer was updated in this PR — n/aschema/invalid/gained a fixture proving it is enforced — n/a🤖 Generated with Claude Code