Skip to content

fix(nav): allow collapsible items without icons #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NriotHrreion merged 1 commit into from
Sep 10, 2026
Merged

fix(nav): allow collapsible items without icons #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/ui/src/base/nav/nav.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,14 +551,17 @@ describe("GlCollapsibleNav", () => {
expect(markup).toContain("data-disabled=\"\"");
});

it("requires a direct leading and an accessible label for complex content", () => {
expect(() => renderToStaticMarkup(
it("allows text-only items and requires an accessible label for complex content", () => {
const textOnlyMarkup = renderToStaticMarkup(
<GlNavProvider>
<GlCollapsibleNav>
<GlNavItem><GlNavButton>Issues</GlNavButton></GlNavItem>
Comment thread
NriotHrreion marked this conversation as resolved.
</GlCollapsibleNav>
</GlNavProvider>,
)).toThrow("requires a direct leading GlIcon or GlAvatar");
);

expect(textOnlyMarkup).toContain("Issues");
expect(textOnlyMarkup).not.toContain("gl-nav-item-has-start-slot");
expect(() => renderToStaticMarkup(
<GlNavProvider>
<GlCollapsibleNav>
Expand Down
3 changes: 0 additions & 3 deletions packages/ui/src/base/nav/nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,9 +349,6 @@ export function useNavButtonInternal(
invariant(component, "isIconOnly requires a leading GlIcon or GlAvatar.");
}
if(isIconOnly && !ariaLabel) invariant(component, "isIconOnly requires aria-label.");
if(isCollapsibleTopLevel && !leading) {
invariant(component, "requires a direct leading GlIcon or GlAvatar in GlCollapsibleNav.");
}
if(isCollapsibleTopLevel && !ariaLabel && !derivedLabel) {
invariant(component, "requires aria-label when its label is not simple text.");
}
Expand Down