Skip to content

fix(nav): allow collapsible items without icons - #85

Merged
NriotHrreion merged 1 commit into
mainfrom
fix/collapsible-nav-icon-optional
Sep 10, 2026
Merged

fix(nav): allow collapsible items without icons#85
NriotHrreion merged 1 commit into
mainfrom
fix/collapsible-nav-icon-optional

Conversation

@NriotHrreion

Copy link
Copy Markdown
Member

No description provided.

@NriotHrreion NriotHrreion added this to the 0.1.0 milestone Sep 10, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T06:52:50.855431Z 8c4e6e8 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying gitlab-ui-react-story with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8c4e6e8
Status: ✅  Deploy successful!
Preview URL: https://6b99a9db.gitlab-ui-react.pages.dev
Branch Preview URL: https://fix-collapsible-nav-icon-opt.gitlab-ui-react.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying gitlab-ui-react-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8c4e6e8
Status: ✅  Deploy successful!
Preview URL: https://dbfa0283.gitlab-ui-react-website.pages.dev
Branch Preview URL: https://fix-collapsible-nav-icon-opt.gitlab-ui-react-website.pages.dev

View logs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c4e6e830b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/ui/src/base/nav/nav.test.tsx
@NriotHrreion

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 8c4e6e830b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@NriotHrreion
NriotHrreion merged commit 2276b44 into main Sep 10, 2026
4 checks passed
@NriotHrreion
NriotHrreion deleted the fix/collapsible-nav-icon-optional branch September 10, 2026 06:53
@github-actions github-actions Bot mentioned this pull request Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant