Skip to content

fix: handle undeliverable RxJava network exceptions globally #6316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mahibi merged 1 commit into from
Jun 4, 2026
+14 −0
Merged

fix: handle undeliverable RxJava network exceptions globally #6316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/src/main/java/com/nextcloud/talk/application/NextcloudTalkApplication.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,13 @@ import com.vanniktech.emoji.EmojiManager
import com.vanniktech.emoji.google.GoogleEmojiProvider
import de.cotech.hw.SecurityKeyManager
import de.cotech.hw.SecurityKeyManagerConfig
import io.reactivex.exceptions.UndeliverableException
import io.reactivex.plugins.RxJavaPlugins
import okhttp3.OkHttpClient
import org.conscrypt.Conscrypt
import org.webrtc.PeerConnectionFactory
import java.io.IOException
import java.net.SocketException
import java.security.Security
import java.util.concurrent.TimeUnit
import javax.inject.Inject
Expand Down Expand Up @@ -122,6 +126,16 @@ class NextcloudTalkApplication :
Log.d(TAG, "onCreate")
sharedApplication = this

RxJavaPlugins.setErrorHandler { e ->
var throwable: Throwable = if (e is UndeliverableException) e.cause ?: e else e
if (throwable is IOException || throwable is SocketException) {
Log.w(TAG, "Undeliverable network exception ignored", throwable)
return@setErrorHandler
}
Thread.currentThread().uncaughtExceptionHandler
?.uncaughtException(Thread.currentThread(), throwable)
}

val securityKeyManager = SecurityKeyManager.getInstance()
val securityKeyConfigBuilder = SecurityKeyManagerConfig.Builder()
.setEnableDebugLogging(BuildConfig.DEBUG)
Expand Down
Loading