fix: handle undeliverable RxJava network exceptions globally#6316
Merged
Conversation
Add a global RxJavaPlugins error handler in NextcloudTalkApplication to prevent crashes caused by ConnectException (ECONNREFUSED) arriving after a subscriber has already been disposed (e.g. user navigated away while a network call was in-flight). IOException and SocketException are logged and ignored since they represent expected network conditions. All other undeliverable exceptions are still forwarded to the uncaught exception handler so real bugs continue to surface as crashes. Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Collaborator
Author
|
/backport to stable-24.0 |
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/26967958809/artifacts/7418499212 |
mahibi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a global RxJavaPlugins error handler in NextcloudTalkApplication to
prevent crashes caused by ConnectException (ECONNREFUSED) arriving after
a subscriber has already been disposed (e.g. user navigated away while a
network call was in-flight).
IOException and SocketException are logged and ignored since they
represent expected network conditions. All other undeliverable exceptions
are still forwarded to the uncaught exception handler so real bugs
continue to surface as crashes.
🏁 Checklist
/backport to stable-xx.x