Skip to content

fix(dashboard): use non-deprecated functions + make tests work at night - #62682

Merged
CarlSchwan merged 2 commits into
masterfrom
fix/dash
Jul 30, 2026
Merged

fix(dashboard): use non-deprecated functions + make tests work at night#62682
CarlSchwan merged 2 commits into
masterfrom
fix/dash

Conversation

@susnux

@susnux susnux commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  1. Use the non deprecated signature of t
  2. Added some context for translators as there might be something like "good morning, X" for the night in other languages.
  3. Fix tests there is no "Good night" its just "Hello" in English

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

susnux added 2 commits July 30, 2026 11:21
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the Nextcloud 35 milestone Jul 30, 2026
@susnux
susnux requested a review from a team as a code owner July 30, 2026 09:24
@susnux susnux added bug 3. to review Waiting for reviews labels Jul 30, 2026
@susnux
susnux removed the request for review from a team July 30, 2026 09:24
@susnux

susnux commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@susnux

susnux commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@susnux
susnux requested review from julien-nc and pringelmann and removed request for nfebe and skjnldsv July 30, 2026 09:25
@CarlSchwan
CarlSchwan enabled auto-merge July 30, 2026 09:55
@CarlSchwan
CarlSchwan merged commit 368f338 into master Jul 30, 2026
246 of 248 checks passed
@CarlSchwan
CarlSchwan deleted the fix/dash branch July 30, 2026 09:57
@backportbot

backportbot Bot commented Jul 30, 2026

Copy link
Copy Markdown

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/62682/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3e9ecdd5 c84cdcd7

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/62682/stable33

Error: Failed to check for changes with origin/stable33: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

backportbot Bot commented Jul 30, 2026

Copy link
Copy Markdown

The backport to stable34 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable34
git pull origin stable34

# Create the new backport branch
git checkout -b backport/62682/stable34

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3e9ecdd5 c84cdcd7

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/62682/stable34

Error: Failed to check for changes with origin/stable34: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants