Skip to content

fix(core): prevent double-submit on login flow grant page #62357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okxint wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(core): prevent double-submit on login flow grant page #62357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions core/src/views/LoginFlowGrant.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ import { loadState } from '@nextcloud/initial-state'
import { t } from '@nextcloud/l10n'
import { confirmPassword, isPasswordConfirmationRequired, PwdConfirmationMode } from '@nextcloud/password-confirmation'
import NcButton from '@nextcloud/vue/components/NcButton'
import NcLoadingIcon from '@nextcloud/vue/components/NcLoadingIcon'
import NcNoteCard from '@nextcloud/vue/components/NcNoteCard'
import { ref } from 'vue'
import LoginFlowContainer from '../components/LoginFlow/LoginFlowContainer.vue'

const {
Expand Down Expand Up @@ -40,19 +42,31 @@ const {

const requestToken = getRequestToken()

const isSubmitting = ref(false)

/**
* Handle submit event to confirm password if required
*
* @param event - The submit event
*/
async function onSubmit(event: SubmitEvent) {
if (isPasswordConfirmationRequired(PwdConfirmationMode.Lax)) {
if (isSubmitting.value) {
event.preventDefault()
event.stopPropagation()
return
}

isSubmitting.value = true
try {
if (isPasswordConfirmationRequired(PwdConfirmationMode.Lax)) {
event.preventDefault()
event.stopPropagation()

await confirmPassword()
;(event.target as HTMLFormElement).submit()
return false
await confirmPassword()
;(event.target as HTMLFormElement).submit()
return
}
} finally {
isSubmitting.value = false
}
}
</script>
Expand Down Expand Up @@ -90,7 +104,10 @@ async function onSubmit(event: SubmitEvent) {
name="providedRedirectUri"
:value="providedRedirectUri">

<NcButton :class="$style.loginFlowGrant__button" type="submit" variant="primary">
<NcButton :class="$style.loginFlowGrant__button" :disabled="isSubmitting" type="submit" variant="primary">
<template v-if="isSubmitting" #icon>
<NcLoadingIcon />
</template>
{{ t('core', 'Grant access') }}
</NcButton>
</form>
Expand Down
Loading