fix(core): prevent double-submit on login flow grant page - #62357
Open
okxint wants to merge 1 commit into
Open
Conversation
Add isSubmitting guard to onSubmit so the button is disabled and shows a loading spinner as soon as the first submit fires. A second click while the form is in-flight is dropped via event.preventDefault(). Fixes: nextcloud#62327 Assisted-by: ClaudeCode:claude-sonnet-4-6
okxint
requested review from
kristian-zendato,
nfebe and
sorbaugh
and removed request for
a team
July 21, 2026 07:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62327
The Vue rewrite of
LoginFlowGrantdropped the disable-on-submit guard that existed in the oldgrant.js(added in #33164). Without it, Chrome's double-fire behavior or a fast second click sends two POST requests before the first response arrives, which can result in duplicate grant confirmations.Fix: add an
isSubmittingref that blocks re-entry intoonSubmitand disables the button while the request is in flight. ANcLoadingIconis shown in the#iconslot during submission, following the same pattern used inPublicPageMenuExternalDialog.vue.