Skip to content

test(files): migrate end-to-end tests to PlayWright - #61751

Merged
sorbaugh merged 2 commits into
masterfrom
test/files-pw
Jul 7, 2026
Merged

test(files): migrate end-to-end tests to PlayWright#61751
sorbaugh merged 2 commits into
masterfrom
test/files-pw

Conversation

@susnux

@susnux susnux commented Jul 3, 2026

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

Migrate all remaining files e2e tests from Cypress to PlayWright.

AI was used for migration but changes are manually reviewed and adjusted where needed.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux susnux changed the title Test/files pw test(files): migrate end-to-end tests to PlayWright Jul 3, 2026
@susnux susnux added 3. to review Waiting for reviews tests Related to tests CI ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jul 3, 2026
@susnux susnux added this to the Nextcloud 35 milestone Jul 3, 2026
@susnux
susnux requested review from CarlSchwan and pringelmann July 3, 2026 14:54

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While playwright has locator.drop it does not account for the dragenter we need for the drop area to become visible. Also it does not allow to fake dropping folders 😔

@susnux
susnux marked this pull request as ready for review July 4, 2026 21:07
@susnux
susnux requested review from a team as code owners July 4, 2026 21:07
@susnux
susnux requested review from come-nc, nfebe, skjnldsv and sorbaugh and removed request for a team July 4, 2026 21:07
Comment thread tests/playwright/support/utils/viewport.ts

@pringelmann pringelmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for keeping the momentum on this 🦾

Just one comment on the viewport check returning false negatives

@come-nc
come-nc removed their request for review July 6, 2026 13:15
susnux added 2 commits July 6, 2026 18:22
Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@sorbaugh
sorbaugh merged commit 7c41ebc into master Jul 7, 2026
244 of 265 checks passed
@sorbaugh
sorbaugh deleted the test/files-pw branch July 7, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted CI ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants