chore: roll to Playwright v1.62.1 - #628
Conversation
|
hi, thank you for your contribution! Before I start reviewing it - did you use the https://github.com/mxschmitt/playwright-go/tree/main/.claude/skills/roll-playwright skill for it? |
Yes... followed the roll skill. • Java: microsoft/playwright-java#1951 (microsoft/playwright-java#1951) (1.62.0-alpha, per-upstream-PR breakdown) and #1954 (microsoft/playwright-java#1954) (1.62.0, including the interceptAPIRequests revert) |
|
Thanks for this — nice, thorough roll, and CI's fully green across the matrix. Went through it locally (incl. a security-focused pass) and have a few notes:
Possible follow-up (not a blocker): Nice fix: removing the orphaned pending-callback in One process note: the PR body cites Python and .NET as cross-binding references but not Java (the real Java roll was Nothing here blocks merging — great work overall. 🙏 |
Adds a mandatory footer to roll-playwright's Step 10 PR-creation instructions identifying the PR as skill-generated, listing the sibling (python/java/dotnet) reference PRs used, and the verify-parity.sh outcome. Doubles as a forcing function for the Step 1 requirement to check all three sibling clients, which PR #628 skipped (only cited python + dotnet).
mxschmitt
left a comment
There was a problem hiding this comment.
Reviewed locally (incl. a full security pass across two subagents) — see comment above for detailed notes. CI is green across the full matrix, no security blockers found, and the couple of follow-up suggestions (storage-state file permissions, citing all three sibling clients on future rolls) are non-blocking. Approving.
Rolls the bundled driver from v1.61.1 to v1.62.1 and ports the v1.62 client
surface, using the v1.62.0 Python and .NET rolls as
cross-binding references. .
New APIs
ScrollMode(auto/none) on the affected action options.BrowserContextstorage state.APIResponse.Timing().ResponseEnd.Locator.WaitForFunction.Behavior changes ported
protocol.
driver backpressure and surfacing callback panics through the connection.
responseEndTimingin API responses.Fixes / internal
PLAYWRIGHT_CLI_PATHcompatible with external driver layouts.Protocol and generation notes
packages/protocol/spec/*.ymlis the Playwright client/driver wire-protocolsource.
docs/src/api/*.md(includingparams.md),with Go language annotations supplied by
patches/main.patch.Go diff.
Validation
gofumpt— cleangolangci-lint run ./...— cleango vet ./...— passedBROWSER=chromium HEADLESS=1 go test -v --race ./... -count=1— passedand WebKit; stable and oldstable Go; lint and examples:
https://github.com/lucastsudaka/playwright-go/actions/runs/31560409443