docs(skill): require roll PRs to note they were skill-generated - #629
Merged
Conversation
Adds a mandatory footer to roll-playwright's Step 10 PR-creation instructions identifying the PR as skill-generated, listing the sibling (python/java/dotnet) reference PRs used, and the verify-parity.sh outcome. Doubles as a forcing function for the Step 1 requirement to check all three sibling clients, which PR #628 skipped (only cited python + dotnet).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #628 (a roll PR generated by the
roll-playwrightskill), it wasn't obvious at a glance that the PR was skill-generated, and the PR body only cited Python and .NET as cross-binding references — Java was skipped, despite Step 1 explicitly requiring all three.This adds a mandatory footer to the skill's Step 10 PR-creation instructions:
This makes future skill-generated rolls identifiable, and doubles as a forcing function for the "check all three siblings" rule.
🤖 Generated with Claude Code