🐛 Make RL circuit sampling seed-aware - #781
Merged
flowerthrower merged 1 commit intoAug 27, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
12 tasks
flowerthrower
force-pushed
the
v3/reproducible-rl-seeding
branch
from
August 27, 2026 11:08
4010c51 to
d730db4
Compare
Signed-off-by: flowerthrower <flowerthrower@users.noreply.github.com> Assisted-by: GPT 5.6 via Codex
flowerthrower
force-pushed
the
v3/reproducible-rl-seeding
branch
from
August 27, 2026 13:09
d730db4 to
788afde
Compare
Base automatically changed from
v3/paper-tket-passes
to
v3/667-stochastic-actions
August 27, 2026 13:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Makes RL training-circuit sampling follow Gymnasium's standard seed lifecycle.
PredictorEnvnow usesself.np_random, which is initialized and reseeded byEnv.reset(seed=...), instead of a separate generator fixed to seed 10. Training-circuit paths are sorted before indexed sampling so equal seeds select equal circuits across filesystems.Compiler-specific seeds, flat-policy defaults, ML estimator seeds, and experiment-only RNGs are unchanged because they already match the intended behavior or are outside this PR's scope.
This draft is stacked on #780. It intentionally contains only the raw seeding fix; documentation and new tests are deferred.
Validation
reset(seed=7)selects the same training circuitsrc/git diff --checkChecklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖.