remove!: Removes MongoDB::Atlas::DataLakePipeline and MongoDB::Atlas::DataLakes resources#1468
remove!: Removes MongoDB::Atlas::DataLakePipeline and MongoDB::Atlas::DataLakes resources#1468
MongoDB::Atlas::DataLakePipeline and MongoDB::Atlas::DataLakes resources#1468Conversation
MongoDB::Atlas::DataLakePipeline and MongoDB::Atlas::DataLakes resources
|
|
||
| ### Resource Status Table | ||
|
|
||
| | # | Resource | Status | Examples | Local Testing Scripts | |
There was a problem hiding this comment.
removed # column as it's hard to maintain and an ordered list can't be in a table (not that I know of)
|
There are still occurrences of Data Lake in some resources like database user, private-endpoint-adl, federated-database-instance. I'm looking to see if we should upgrade the SDK for these to stay updated with latest APIs. |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the EOL'd (End-of-Life) MongoDB::Atlas::DataLakePipeline and MongoDB::Atlas::DataLakes resources following their deprecation announcement. The changes clean up all related code, tests, documentation, and examples for these deprecated Data Lake features.
Key Changes
- Removed entire
datalakesanddata-lake-pipelineresource directories containing source code, schemas, and configuration - Deleted example CloudFormation templates and test files for both resources
- Updated main README to remove references to the deprecated resources from the resource status table
Reviewed Changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/data-lakes/datalake.json | Removed example CloudFormation template for DataLakes resource |
| examples/data-lake-pipeline/datalakepipeline.json | Removed example CloudFormation template for DataLakePipeline resource |
| cfn-resources/datalakes/* | Removed entire datalakes resource implementation including Go code, schemas, docs, and tests |
| cfn-resources/data-lake-pipeline/* | Removed entire data-lake-pipeline resource implementation including Go code, schemas, docs, and tests |
| cfn-resources/README.md | Updated resource status table to remove entries for deprecated resources |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EspenAlbert
left a comment
There was a problem hiding this comment.
TY!
A shame we cannot update the already released versions of these in the cloudformation registry.
Proposed changes
Jira ticket: CLOUDP-344019
These resources have now EOL'd, see https://www.mongodb.com/products/updates/product-support-deprecation
Link to any related issue(s): CLOUDP-344019
Type of change:
expected)
Manual QA performed:
Required Checklist:
make fmtand formatted my codeworks in Atlas
Further comments