Skip to content

remove!: Removes MongoDB::Atlas::DataLakePipeline and MongoDB::Atlas::DataLakes resources#1468

Merged
maastha merged 6 commits intomasterfrom
CLOUDP-344019-data-lake
Oct 30, 2025
Merged

remove!: Removes MongoDB::Atlas::DataLakePipeline and MongoDB::Atlas::DataLakes resources#1468
maastha merged 6 commits intomasterfrom
CLOUDP-344019-data-lake

Conversation

@maastha
Copy link
Copy Markdown
Collaborator

@maastha maastha commented Oct 30, 2025

Proposed changes

Jira ticket: CLOUDP-344019

These resources have now EOL'd, see https://www.mongodb.com/products/updates/product-support-deprecation

Link to any related issue(s): CLOUDP-344019

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

@maastha maastha changed the title remove!: Cloudp 344019 data lake remove!: Removes MongoDB::Atlas::DataLakePipeline and MongoDB::Atlas::DataLakes resources Oct 30, 2025
Comment thread cfn-resources/README.md

### Resource Status Table

| # | Resource | Status | Examples | Local Testing Scripts |
Copy link
Copy Markdown
Collaborator Author

@maastha maastha Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed # column as it's hard to maintain and an ordered list can't be in a table (not that I know of)

@maastha
Copy link
Copy Markdown
Collaborator Author

maastha commented Oct 30, 2025

There are still occurrences of Data Lake in some resources like database user, private-endpoint-adl, federated-database-instance. I'm looking to see if we should upgrade the SDK for these to stay updated with latest APIs.

@maastha maastha marked this pull request as ready for review October 30, 2025 08:58
@maastha maastha requested a review from a team as a code owner October 30, 2025 08:58
Copilot AI review requested due to automatic review settings October 30, 2025 08:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the EOL'd (End-of-Life) MongoDB::Atlas::DataLakePipeline and MongoDB::Atlas::DataLakes resources following their deprecation announcement. The changes clean up all related code, tests, documentation, and examples for these deprecated Data Lake features.

Key Changes

  • Removed entire datalakes and data-lake-pipeline resource directories containing source code, schemas, and configuration
  • Deleted example CloudFormation templates and test files for both resources
  • Updated main README to remove references to the deprecated resources from the resource status table

Reviewed Changes

Copilot reviewed 54 out of 54 changed files in this pull request and generated no comments.

Show a summary per file
File Description
examples/data-lakes/datalake.json Removed example CloudFormation template for DataLakes resource
examples/data-lake-pipeline/datalakepipeline.json Removed example CloudFormation template for DataLakePipeline resource
cfn-resources/datalakes/* Removed entire datalakes resource implementation including Go code, schemas, docs, and tests
cfn-resources/data-lake-pipeline/* Removed entire data-lake-pipeline resource implementation including Go code, schemas, docs, and tests
cfn-resources/README.md Updated resource status table to remove entries for deprecated resources

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!
A shame we cannot update the already released versions of these in the cloudformation registry.

@maastha maastha added this pull request to the merge queue Oct 30, 2025
Merged via the queue into master with commit 29213d7 Oct 30, 2025
41 checks passed
@maastha maastha deleted the CLOUDP-344019-data-lake branch October 30, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants