Skip to content

chore: Remove all occurrences of data lake#1474

Merged
lantoli merged 1 commit intomasterfrom
CLOUDP-344019_data_lake
Nov 6, 2025
Merged

chore: Remove all occurrences of data lake#1474
lantoli merged 1 commit intomasterfrom
CLOUDP-344019_data_lake

Conversation

@lantoli
Copy link
Copy Markdown
Member

@lantoli lantoli commented Nov 6, 2025

Remove all occurrences of data lake.

  • Data Lake was the previous name for Atlas Data Federation, most of the changes in this PR are about this.
  • Remove MongoDB::Atlas::PrivateEndpointAD that was not removed earlier.
  • There are still some references to DataLake in Atlas SDK structs that will be updated when changed in Atlas.

Jira ticket: CLOUDP-344019

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

@lantoli lantoli marked this pull request as ready for review November 6, 2025 07:41
@lantoli lantoli requested a review from a team as a code owner November 6, 2025 07:41
Copilot AI review requested due to automatic review settings November 6, 2025 07:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@@ -1,17 +0,0 @@
{
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, this was a left over from original PR #1468?

Copy link
Copy Markdown
Member Author

@lantoli lantoli Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, similarly to Terraform, adding to PR description

@lantoli lantoli added this pull request to the merge queue Nov 6, 2025
Merged via the queue into master with commit f4d757e Nov 6, 2025
50 checks passed
@lantoli lantoli deleted the CLOUDP-344019_data_lake branch November 6, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants