Skip to content

fix(filesystem): reject move_file when destination exists #4668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
re2zero wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Open

fix(filesystem): reject move_file when destination exists #4668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/filesystem/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,6 +631,20 @@ server.registerTool(
async (args: z.infer<typeof MoveFileArgsSchema>) => {
const validSourcePath = await validatePath(args.source);
const validDestPath = await validatePath(args.destination);

// Check if destination exists (documented behavior: fail if destination exists)
try {
await fs.stat(validDestPath);
throw new Error(`Destination already exists: ${args.destination}`);
} catch (err: any) {
if (err instanceof Error && err.message.startsWith("Destination already exists")) {
throw err;
}
if ((err as NodeJS.ErrnoException).code !== "ENOENT") {
throw err;
}
}

await fs.rename(validSourcePath, validDestPath);
const text = `Successfully moved ${args.source} to ${args.destination}`;
const contentBlock = { type: "text" as const, text };
Expand Down